Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-08 Thread Linus Walleij
On Mon, Aug 7, 2023 at 3:10 PM Mark Brown wrote: > On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote: > > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina > > wrote: > > > > +#include "linux/bitfield.h" > > > Really? I don't think there is such a file there. > > > Do you mean and does t

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. > > This pinmux support handles the pin muxing part (pins RP(

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Herve Codina
Hi Linus, Andrew, On Mon, 7 Aug 2023 15:17:11 +0200 Andrew Lunn wrote: > On Mon, Aug 07, 2023 at 03:06:42PM +0200, Linus Walleij wrote: > > On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij > > wrote: > > > > > > Signed-off-by: Herve Codina > > > > > > So it is a bridge chip? Please use that

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Herve Codina
Hi Linus, On Mon, 7 Aug 2023 15:05:15 +0200 Linus Walleij wrote: > Hi Herve, > > thanks for your patch! > > First: is this patch something we could merge separately? I don't see > any dependency on the other patches. It depends on pef2256: in drivers/pinctrl/Kconfig: --- 8< --- +config PINCTR

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Andrew Lunn
On Mon, Aug 07, 2023 at 03:06:42PM +0200, Linus Walleij wrote: > On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij wrote: > > > > Signed-off-by: Herve Codina > > > > So it is a bridge chip? Please use that terminology since Linux > > DRM often talks about bridges. > > Replying to self: no it's not a

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Mark Brown
On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote: > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina wrote: > > +#include "linux/bitfield.h" > Really? I don't think there is such a file there. > Do you mean and does this even compile? #include "" means "try the local directory first

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Linus Walleij
On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij wrote: > > Signed-off-by: Herve Codina > > So it is a bridge chip? Please use that terminology since Linux > DRM often talks about bridges. Replying to self: no it's not a bridge, it's a WAN thingy. So perhaps write that this is a WAN interface adap

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Linus Walleij
Hi Herve, thanks for your patch! First: is this patch something we could merge separately? I don't see any dependency on the other patches. On Wed, Jul 26, 2023 at 5:04 PM Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required inter

[PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-07-26 Thread Herve Codina
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. This pinmux support handles the pin muxing part (pins RP(A..D) and pins XP(A..D)) of the PEF2256. Signed-off-by: H