Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-02-07 Thread Jonathan Neuschäfer
On Wed, Feb 07, 2018 at 01:29:45PM +0100, Linus Walleij wrote: > On Mon, Jan 22, 2018 at 6:04 AM, Jonathan Neuschäfer > wrote: > > > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller > > that supports a configurable number of pins (up to 32), interrupts, and > > some special m

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-02-07 Thread Linus Walleij
On Mon, Jan 22, 2018 at 6:04 AM, Jonathan Neuschäfer wrote: > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller > that supports a configurable number of pins (up to 32), interrupts, and > some special mechanisms to share the controller between the system's > security processor

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-31 Thread Jonathan Neuschäfer
Hi, On Sun, Jan 28, 2018 at 07:31:58PM +0200, Andy Shevchenko wrote: > On Mon, Jan 22, 2018 at 7:04 AM, Jonathan Neuschäfer > wrote: > > Style issues below. > > > +#define HW_GPIO_OWNER 0x3c > > + > > + > > +struct hlwd_gpio { > > No need extra empty line in between. Ok. > > +

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-28 Thread Andy Shevchenko
On Mon, Jan 22, 2018 at 7:04 AM, Jonathan Neuschäfer wrote: Style issues below. > +#define HW_GPIO_OWNER 0x3c > + > + > +struct hlwd_gpio { No need extra empty line in between. > + struct gpio_chip gpioc; > + void __iomem *regs; > + struct device *dev; > +}; > + > +s

[PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-21 Thread Jonathan Neuschäfer
The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller that supports a configurable number of pins (up to 32), interrupts, and some special mechanisms to share the controller between the system's security processor (an ARM926) and the PowerPC CPU. Pin multiplexing is not supported.