Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-22 Thread Thiago Jung Bauermann
efault? > > > > As far as I know, variables on the stack are not initialized. Only > > global > > and static variables are. > > But designated initializers will do it. Here is the new version, relying on the default value for kexec_buf.skip_checksum. A nice side effect i

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Thiago Jung Bauermann
Am Montag, 22 August 2016, 11:36:43 schrieb Dave Young: > On 08/22/16 at 12:25am, Thiago Jung Bauermann wrote: > > Am Montag, 22 August 2016, 11:17:45 schrieb Dave Young: > > > On 08/18/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > > Hello Dave, > > > > > > > > Thanks for your review! > > > >

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Dave Young
On 08/22/16 at 12:25am, Thiago Jung Bauermann wrote: > Am Montag, 22 August 2016, 11:17:45 schrieb Dave Young: > > On 08/18/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Hello Dave, > > > > > > Thanks for your review! > > > > > > [ Trimming down Cc: list a little to try to clear the "too

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Thiago Jung Bauermann
Am Montag, 22 August 2016, 11:17:45 schrieb Dave Young: > On 08/18/16 at 06:09pm, Thiago Jung Bauermann wrote: > > Hello Dave, > > > > Thanks for your review! > > > > [ Trimming down Cc: list a little to try to clear the "too many > > recipients"> > > mailing list restriction. ] > > I also

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-21 Thread Dave Young
of struct kexec_buf put it on the stack so the field needs > to be initialized explicitly. > > -- > []'s > Thiago Jung Bauermann > IBM Linux Technology Center > > > Subject: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for > some segments. > &g

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-18 Thread Thiago Jung Bauermann
ted it that way, though in practice all current users of struct kexec_buf put it on the stack so the field needs to be initialized explicitly. -- []'s Thiago Jung Bauermann IBM Linux Technology Center Subject: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments. Add

Re: [PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-18 Thread Dave Young
On 08/13/16 at 12:18am, Thiago Jung Bauermann wrote: > Adds checksum argument to kexec_add_buffer specifying whether the given > segment should be part of the checksum calculation. > Since it is used with add buffer, could it be added to kbuf as a new field? Like kbuf.no_checksum, default value

[PATCH v2 3/6] kexec_file: Allow skipping checksum calculation for some segments.

2016-08-12 Thread Thiago Jung Bauermann
Adds checksum argument to kexec_add_buffer specifying whether the given segment should be part of the checksum calculation. The next patch will add a way to update segments after a kimage is loaded. Segments that will be updated in this way should not be checksummed, otherwise they will cause the