Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Grant Likely
On Tue, Aug 10, 2010 at 1:14 AM, David Brownell wrote: > > > --- On Mon, 8/9/10, Grant Likely wrote: > > >> > +       nr_parts = >> of_mtd_parse_partitions(&spi->dev, np, &parts); > > Let's keep OF-specific logic out of drivers like > this one ...  intended to work without OF. > > NAK on adding d

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread David Brownell
--- On Mon, 8/9/10, Grant Likely wrote: > > +       nr_parts = > of_mtd_parse_partitions(&spi->dev, np, &parts); Let's keep OF-specific logic out of drivers like this one ... intended to work without OF. NAK on adding dependencies like OF to drivers and other infrastructure that starts gene

Re: [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-09 Thread Grant Likely
On Mon, Aug 2, 2010 at 1:52 AM, Mingkai Hu wrote: > Signed-off-by: Mingkai Hu > --- > > v2: >  - Move the flash partition function from of_spi.c to MTD driver > >  drivers/mtd/devices/m25p80.c |   29 + >  1 files changed, 29 insertions(+), 0 deletions(-) > > diff --git

[PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-02 Thread Mingkai Hu
Signed-off-by: Mingkai Hu --- v2: - Move the flash partition function from of_spi.c to MTD driver drivers/mtd/devices/m25p80.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index