Re: [PATCH v2 4/4] powerpc/pseries/cpuhp: remove obsolete comment from pseries_cpu_die

2021-10-11 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Daniel Henrique Barboza writes: >>> This is enough to say that we can't easily see the history behind this >>> comment. >>> I also believe that we're better of without it since it doesn't make sense >>> with the current codebase. >> >> It was

Re: [PATCH v2 4/4] powerpc/pseries/cpuhp: remove obsolete comment from pseries_cpu_die

2021-09-29 Thread Nathan Lynch
Michael Ellerman writes: > Daniel Henrique Barboza writes: >> This is enough to say that we can't easily see the history behind this >> comment. >> I also believe that we're better of without it since it doesn't make sense >> with the current codebase. > > It was added by the original CPU

Re: [PATCH v2 4/4] powerpc/pseries/cpuhp: remove obsolete comment from pseries_cpu_die

2021-09-28 Thread Michael Ellerman
Daniel Henrique Barboza writes: > On 9/27/21 17:19, Nathan Lynch wrote: >> This comment likely refers to the obsolete DLPAR workflow where some >> resource state transitions were driven more directly from user space >> utilities, but it also seems to contradict itself: "Change isolate state to >>

Re: [PATCH v2 4/4] powerpc/pseries/cpuhp: remove obsolete comment from pseries_cpu_die

2021-09-28 Thread Daniel Henrique Barboza
On 9/27/21 17:19, Nathan Lynch wrote: This comment likely refers to the obsolete DLPAR workflow where some resource state transitions were driven more directly from user space utilities, but it also seems to contradict itself: "Change isolate state to Isolate [...]" is at odds with the

[PATCH v2 4/4] powerpc/pseries/cpuhp: remove obsolete comment from pseries_cpu_die

2021-09-27 Thread Nathan Lynch
This comment likely refers to the obsolete DLPAR workflow where some resource state transitions were driven more directly from user space utilities, but it also seems to contradict itself: "Change isolate state to Isolate [...]" is at odds with the preceding sentences, and it does not relate at