Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency

2023-03-02 Thread Michael Ellerman
Jiaxun Yang writes: >> 2023年3月1日 13:06,Christoph Hellwig 写道: >> >>> - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE >> >> Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now, >> or even better should be doing that in the patch adding that >> symbol? > > If I read the

Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency

2023-03-01 Thread Jiaxun Yang
> 2023年3月1日 13:06,Christoph Hellwig 写道: > >> - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE > > Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now, > or even better should be doing that in the patch adding that > symbol? If I read the code correctly for powerpc

Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency

2023-03-01 Thread Christoph Hellwig
> - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now, or even better should be doing that in the patch adding that symbol? In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing

[PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency

2023-02-23 Thread Jiaxun Yang
As for now all arches have dma_default_coherent matched with default DMA coherency for of devices, so there is no need to have a standalone config option. Note for PowerPC: CONFIG_OF_DMA_DEFUALT_COHERENT was only selected when CONFIG_NOT_COHERENT_CACHE is false, in this case dma_default_coherent