On Apr 11, 2008, at 10:49, Paul Gortmaker wrote:
In message: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically
on 10/04/2008 Andy Fleming wrote:
TBIPA needs to be set to a value (on connected MDIO buses) that
doesn't
conflict with PHYs on the bus. By hardcoding it to 0x1f, we
Andy Fleming wrote:
I tried. Technically, we can. But the issue is that struct gfar
*enet_regs->gfar_mii_regs is declared:
u8 gfar_mii_regs[24];
I could not find any sequence of castings that made the warning go away
about casting that to a struct gfar_mii __iomem *. And that includes
muc
On Apr 11, 2008, at 10:31, Scott Wood wrote:
On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote:
+ /*
+* This is mildly evil, but so is our hardware for doing this.
+* Also, we have to cast back to struct gfar_mii because of
+* definition weirdness done
In message: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically
on 10/04/2008 Andy Fleming wrote:
> TBIPA needs to be set to a value (on connected MDIO buses) that doesn't
> conflict with PHYs on the bus. By hardcoding it to 0x1f, we were preventing
> boards with PHYs at 0x1
On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote:
>
> + /*
> + * This is mildly evil, but so is our hardware for doing this.
> + * Also, we have to cast back to struct gfar_mii because of
> + * definition weirdness done in gianfar.h.
> + */
> + enet_regs =
TBIPA needs to be set to a value (on connected MDIO buses) that doesn't
conflict with PHYs on the bus. By hardcoding it to 0x1f, we were preventing
boards with PHYs at 0x1f from working properly. Instead, scan the bus when
it comes up, and find an address that doesn't have a PHY on it. The TBI P
