Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2017-01-10 Thread Kamalesh Babulal
On Thursday 08 December 2016 11:38 PM, Josh Poimboeuf wrote: The _TIF_ALLWORK_MASK macro automatically includes the least-significant 16 bits of the thread_info flags, which is less than obvious and tends to create confusion and surprises when reading or modifying the code. Define the flags expl

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-19 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. Yes. > Define the flags explicitl

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-16 Thread Josh Poimboeuf
On Fri, Dec 16, 2016 at 03:17:35PM +0100, Petr Mladek wrote: > On Thu 2016-12-08 12:08:27, Josh Poimboeuf wrote: > > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > > 16 bits of the thread_info flags, which is less than obvious and tends > > to create confusion and surpri

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-16 Thread Petr Mladek
On Thu 2016-12-08 12:08:27, Josh Poimboeuf wrote: > The _TIF_ALLWORK_MASK macro automatically includes the least-significant > 16 bits of the thread_info flags, which is less than obvious and tends > to create confusion and surprises when reading or modifying the code. > > Define the flags explici

[PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2016-12-08 Thread Josh Poimboeuf
The _TIF_ALLWORK_MASK macro automatically includes the least-significant 16 bits of the thread_info flags, which is less than obvious and tends to create confusion and surprises when reading or modifying the code. Define the flags explicitly. Signed-off-by: Josh Poimboeuf --- arch/x86/include/a