On Sep 5, 2008, at 5:38 PM, Benjamin Herrenschmidt wrote:
On Fri, 2008-09-05 at 14:44 -0500, Kumar Gala wrote:
I also wonder if you should first ensure that the PTE is invalid and
if not, clear it and flush the TLB page ... Or at least add a
WARN_ON(pte_valid()) in case we get that wrong ...
On Sep 3, 2008, at 10:12 PM, Benjamin Herrenschmidt wrote:
On Wed, 2008-09-03 at 13:09 -0500, Kumar Gala wrote:
There are some minor issues with support 64-bit PTEs on a 32-bit
processor
when dealing with SMP.
* We need to order the stores in set_pte_at to make sure the flag
word
is
On Fri, 2008-09-05 at 14:44 -0500, Kumar Gala wrote:
I also wonder if you should first ensure that the PTE is invalid and
if not, clear it and flush the TLB page ... Or at least add a
WARN_ON(pte_valid()) in case we get that wrong ...
I believe that's an issue since kmap_atomic() will
There are some minor issues with support 64-bit PTEs on a 32-bit processor
when dealing with SMP.
* We need to order the stores in set_pte_at to make sure the flag word
is set second.
* Change pte_clear to use pte_update so only the flag word is cleared
Signed-off-by: Kumar Gala [EMAIL
On Wed, 2008-09-03 at 13:09 -0500, Kumar Gala wrote:
There are some minor issues with support 64-bit PTEs on a 32-bit processor
when dealing with SMP.
* We need to order the stores in set_pte_at to make sure the flag word
is set second.
* Change pte_clear to use pte_update so only the
