Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-15 Thread Shawn Guo
On Wed, Feb 15, 2012 at 10:32:43PM -0700, Grant Likely wrote: ... > That's a bug then. The implementation should work without patch 24. Does > this patch fix it? > Yes, it fixes the problem for me. Regards, Shawn > --- > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 2

Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-15 Thread Grant Likely
On Wed, Feb 15, 2012 at 01:50:02PM -0800, Shawn Guo wrote: > On Wed, Feb 15, 2012 at 01:21:45PM -0700, Grant Likely wrote: > > On Wed, Feb 15, 2012 at 04:04:28PM +0100, Nicolas Ferre wrote: > > > On 02/07/2012 07:07 PM, Nicolas Ferre : > > > > On 01/27/2012 10:36 PM, Grant Likely : > > > >> The 'hi

Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-15 Thread Shawn Guo
On Wed, Feb 15, 2012 at 01:21:45PM -0700, Grant Likely wrote: > On Wed, Feb 15, 2012 at 04:04:28PM +0100, Nicolas Ferre wrote: > > On 02/07/2012 07:07 PM, Nicolas Ferre : > > > On 01/27/2012 10:36 PM, Grant Likely : > > >> The 'hint' used to try and line up irq numbers with hw irq numbers is > > >>

Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-15 Thread Grant Likely
On Wed, Feb 15, 2012 at 04:04:28PM +0100, Nicolas Ferre wrote: > On 02/07/2012 07:07 PM, Nicolas Ferre : > > On 01/27/2012 10:36 PM, Grant Likely : > >> The 'hint' used to try and line up irq numbers with hw irq numbers is > >> rather a hack and not very useful. Now that /proc/interrupts also outp

Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-15 Thread Nicolas Ferre
On 02/07/2012 07:07 PM, Nicolas Ferre : > On 01/27/2012 10:36 PM, Grant Likely : >> The 'hint' used to try and line up irq numbers with hw irq numbers is >> rather a hack and not very useful. Now that /proc/interrupts also outputs >> the hwirq number, it is even less useful to keep around the 'hin

Re: [PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-02-07 Thread Nicolas Ferre
On 01/27/2012 10:36 PM, Grant Likely : > The 'hint' used to try and line up irq numbers with hw irq numbers is > rather a hack and not very useful. Now that /proc/interrupts also outputs > the hwirq number, it is even less useful to keep around the 'hint' heuristic. > > This patch removes it. Gr

[PATCH v3 24/25] irq_domain: remove "hint" when allocating irq numbers

2012-01-27 Thread Grant Likely
The 'hint' used to try and line up irq numbers with hw irq numbers is rather a hack and not very useful. Now that /proc/interrupts also outputs the hwirq number, it is even less useful to keep around the 'hint' heuristic. This patch removes it. Signed-off-by: Grant Likely Cc: Benjamin Herrensch