Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-18 Thread Christophe Leroy
On 12/18/2019 04:32 AM, Daniel Axtens wrote: Daniel Axtens writes: Hi Christophe, I'm working through your feedback, thank you. Regarding this one: --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -2081,7 +2081,14 @@ void show_stack(struct task_struct *tsk,

Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-17 Thread Daniel Axtens
>>[For those not immersed in ppc64, in real mode, the top nibble or 2 bits >>(depending on radix/hash mmu) of the address is ignored. The linear >>mapping is placed at 0xc000. This means that a pointer to >>part of the linear mapping will work both in real mode, where

Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-17 Thread Daniel Axtens
Daniel Axtens writes: > Hi Christophe, > > I'm working through your feedback, thank you. Regarding this one: > >>> --- a/arch/powerpc/kernel/process.c >>> +++ b/arch/powerpc/kernel/process.c >>> @@ -2081,7 +2081,14 @@ void show_stack(struct task_struct *tsk, unsigned >>> long *stack) >>>

Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-17 Thread Daniel Axtens
Hi Christophe, I'm working through your feedback, thank you. Regarding this one: >> --- a/arch/powerpc/kernel/process.c >> +++ b/arch/powerpc/kernel/process.c >> @@ -2081,7 +2081,14 @@ void show_stack(struct task_struct *tsk, unsigned >> long *stack) >> /* >> * See if

Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-13 Thread Christophe Leroy
Le 12/12/2019 à 16:16, Daniel Axtens a écrit : KASAN support on Book3S is a bit tricky to get right: - It would be good to support inline instrumentation so as to be able to catch stack issues that cannot be caught with outline mode. - Inline instrumentation requires a fixed offset.

Re: [PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-12 Thread Jordan Niethe
On Fri, Dec 13, 2019 at 2:19 AM Daniel Axtens wrote: > > KASAN support on Book3S is a bit tricky to get right: > > - It would be good to support inline instrumentation so as to be able to >catch stack issues that cannot be caught with outline mode. > > - Inline instrumentation requires a

[PATCH v3 3/3] powerpc: Book3S 64-bit "heavyweight" KASAN support

2019-12-12 Thread Daniel Axtens
KASAN support on Book3S is a bit tricky to get right: - It would be good to support inline instrumentation so as to be able to catch stack issues that cannot be caught with outline mode. - Inline instrumentation requires a fixed offset. - Book3S runs code in real mode after booting. Most