Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-14 Thread John Hubbard
On 7/13/23 02:08, David Hildenbrand wrote: ...     **WEAK_DECLARATION**   Using weak declarations like __attribute__((weak)) or __weak   can have unintended link defects.  Avoid using them. ...which seems deeply out of touch with how arch layers work these days, doesn't it? (This is not

Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-13 Thread David Hildenbrand
On 12.07.23 22:07, John Hubbard wrote: On 7/11/23 09:09, David Hildenbrand wrote: ... Can we make that a __weak function instead? We can. It is confusing because we do have these two patterns within the kernel where we use #ifndef x #endif vs __weak x What is the recommended way to

Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-12 Thread John Hubbard
On 7/11/23 09:09, David Hildenbrand wrote: ... Can we make that a __weak function instead? We can. It is confusing because we do have these two patterns within the kernel where we use #ifndef x #endif vs __weak x What is the recommended way to override ? I have mostly been using #ifndef

Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-11 Thread David Hildenbrand
On 11.07.23 18:07, Aneesh Kumar K V wrote: On 7/11/23 4:06 PM, David Hildenbrand wrote: On 11.07.23 06:48, Aneesh Kumar K.V wrote: Some architectures would want different restrictions. Hence add an architecture-specific override. Both the PMD_SIZE check and pageblock alignment check are moved

Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-11 Thread Aneesh Kumar K V
On 7/11/23 4:06 PM, David Hildenbrand wrote: > On 11.07.23 06:48, Aneesh Kumar K.V wrote: >> Some architectures would want different restrictions. Hence add an >> architecture-specific override. >> >> Both the PMD_SIZE check and pageblock alignment check are moved there. >> >> Signed-off-by:

Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-11 Thread David Hildenbrand
On 11.07.23 06:48, Aneesh Kumar K.V wrote: Some architectures would want different restrictions. Hence add an architecture-specific override. Both the PMD_SIZE check and pageblock alignment check are moved there. Signed-off-by: Aneesh Kumar K.V --- mm/memory_hotplug.c | 17 -

[PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check

2023-07-10 Thread Aneesh Kumar K.V
Some architectures would want different restrictions. Hence add an architecture-specific override. Both the PMD_SIZE check and pageblock alignment check are moved there. Signed-off-by: Aneesh Kumar K.V --- mm/memory_hotplug.c | 17 - 1 file changed, 12 insertions(+), 5