Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-11-12 Thread Michael Ellerman
On Wed, 2014-11-12 at 15:06 +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-11-12 at 13:23 +1100, Michael Ellerman wrote: On Tue, 2014-11-11 at 14:12 -0700, Bjorn Helgaas wrote: On Thu, Oct 16, 2014 at 09:55:32AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-10-15 at 16:19 -0600,

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-11-11 Thread Bjorn Helgaas
On Thu, Oct 16, 2014 at 09:55:32AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-10-15 at 16:19 -0600, Bjorn Helgaas wrote: PCI/MSI: Add device flag indicating that 64-bit MSIs don't work I'd be happy to merge it, but given what I know now, I would wait and merge it during the

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-11-11 Thread Michael Ellerman
On Tue, 2014-11-11 at 14:12 -0700, Bjorn Helgaas wrote: On Thu, Oct 16, 2014 at 09:55:32AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-10-15 at 16:19 -0600, Bjorn Helgaas wrote: PCI/MSI: Add device flag indicating that 64-bit MSIs don't work I'm still assuming you're going to

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-11-11 Thread Benjamin Herrenschmidt
On Wed, 2014-11-12 at 13:23 +1100, Michael Ellerman wrote: On Tue, 2014-11-11 at 14:12 -0700, Bjorn Helgaas wrote: On Thu, Oct 16, 2014 at 09:55:32AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-10-15 at 16:19 -0600, Bjorn Helgaas wrote: PCI/MSI: Add device flag indicating that

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-11-11 Thread Bjorn Helgaas
On Tue, Nov 11, 2014 at 9:06 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2014-11-12 at 13:23 +1100, Michael Ellerman wrote: On Tue, 2014-11-11 at 14:12 -0700, Bjorn Helgaas wrote: On Thu, Oct 16, 2014 at 09:55:32AM +1100, Benjamin Herrenschmidt wrote: On Wed,

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-15 Thread Bjorn Helgaas
On Wed, Oct 08, 2014 at 04:28:16PM +1100, Benjamin Herrenschmidt wrote: On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: This moves the setting of the quirk flag to the audio driver. While recent ASICs have that problem fixed, they don't seem to be listed in the PCI IDs of the

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-15 Thread Benjamin Herrenschmidt
On Wed, 2014-10-15 at 16:19 -0600, Bjorn Helgaas wrote: PCI/MSI: Add device flag indicating that 64-bit MSIs don't work I'd be happy to merge it, but given what I know now, I would wait and merge it during the v3.19 merge window. It sounds like it's more urgent than that and should be

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-13 Thread Benjamin Herrenschmidt
On Wed, 2014-10-08 at 16:28 +1100, Benjamin Herrenschmidt wrote: Further discussion with the hw teams have revealed that this is still an issue on newer asics so I think your original patch is correct after all. Just disable 64 bit MSIs on all AMD audio PCI ids. Allright, I won't resend

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-13 Thread Alex Deucher
On Mon, Oct 13, 2014 at 4:11 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2014-10-08 at 16:28 +1100, Benjamin Herrenschmidt wrote: Further discussion with the hw teams have revealed that this is still an issue on newer asics so I think your original patch is correct

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-13 Thread Bjorn Helgaas
On Mon, Oct 13, 2014 at 2:11 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2014-10-08 at 16:28 +1100, Benjamin Herrenschmidt wrote: Further discussion with the hw teams have revealed that this is still an issue on newer asics so I think your original patch is correct

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-08 Thread Alex Deucher
On Wed, Oct 8, 2014 at 1:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: This moves the setting of the quirk flag to the audio driver. While recent ASICs have that problem fixed, they don't seem to be listed in the PCI

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-08 Thread Benjamin Herrenschmidt
On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: This moves the setting of the quirk flag to the audio driver. While recent ASICs have that problem fixed, they don't seem to be listed in the PCI IDs of the current driver, so let's quirk all the ATI HDMI for now. The consequences

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-08 Thread Takashi Iwai
At Wed, 08 Oct 2014 16:28:16 +1100, Benjamin Herrenschmidt wrote: On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: This moves the setting of the quirk flag to the audio driver. While recent ASICs have that problem fixed, they don't seem to be listed in the PCI IDs of the

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-07 Thread Alex Deucher
On Tue, Oct 7, 2014 at 12:38 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: From: Signed-off-by: Alex Deucher alexdeuc...@gmail.com A number of radeon cards have a HW limitation causing them to be unable to generate the full 64-bit of address bits for MSIs. This breaks MSIs on

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-07 Thread Benjamin Herrenschmidt
On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: While recent ASICs have that problem fixed, they don't seem to be listed in the PCI IDs of the current driver, so let's quirk all the ATI HDMI for now. The consequences are nil on x86 anyway. Signed-off-by: Alex Deucher

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-07 Thread Alex Deucher
On Tue, Oct 7, 2014 at 7:49 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote: While recent ASICs have that problem fixed, they don't seem to be listed in the PCI IDs of the current driver, so let's quirk all the ATI HDMI for

[PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

2014-10-06 Thread Benjamin Herrenschmidt
From: Signed-off-by: Alex Deucher alexdeuc...@gmail.com A number of radeon cards have a HW limitation causing them to be unable to generate the full 64-bit of address bits for MSIs. This breaks MSIs on some platforms such as POWER machines. We used to have a powerpc specific quirk to address