Re: [PATCH v4] net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs

2023-01-11 Thread Leon Romanovsky
On Wed, Jan 11, 2023 at 10:55:33PM +0300, Esina Ekaterina wrote: > If uhdlc_priv_tsa != 1 then utdm is not initialized. > And if ret != NULL then goto undo_uhdlc_init, where > utdm is dereferenced. Same if dev == NULL. > > Found by Astra Linux on behalf of Linux Verification Center >

Re: [PATCH v4] net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs

2023-01-11 Thread Jakub Kicinski
On Wed, 11 Jan 2023 22:55:33 +0300 Esina Ekaterina wrote: > Signed-off-by: Esina Ekaterina > --- This --- is still indented. On top of that please tag the patch for the tree to which networking maintainers apply fixes (by specifying [PATCH net v5] instead just [PATCH v5] in the subject). And

[PATCH v4] net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs

2023-01-11 Thread Esina Ekaterina
If uhdlc_priv_tsa != 1 then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev == NULL. Found by Astra Linux on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Esina Ekaterina --- v4: Fix style v3: