Re: [PATCH v4] powerpc: Do not make the entire heap executable

2016-08-22 Thread Jason Gunthorpe
On Mon, Aug 22, 2016 at 08:37:05PM +0200, Denys Vlasenko wrote: > >Is this going to break any application ? I am asking because you > >mentioned the patch is lightly tested. > > I booted powerpc64 machine with RHEL7 installation, > it did not catch fire. When I authored the original patch my con

Re: [PATCH v4] powerpc: Do not make the entire heap executable

2016-08-22 Thread Denys Vlasenko
On 08/21/2016 05:47 PM, Aneesh Kumar K.V wrote: Denys Vlasenko writes: On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, or with a toolchain which defaults to it) look like this: [17] .sbss NOBITS 0002aff8 01aff8 14 00 WA 0 0 4 [18] .p

Re: [PATCH v4] powerpc: Do not make the entire heap executable

2016-08-21 Thread Aneesh Kumar K.V
Denys Vlasenko writes: > On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, > or with a toolchain which defaults to it) look like this: > > [17] .sbss NOBITS 0002aff8 01aff8 14 00 WA 0 0 > 4 > [18] .plt NOBITS 0002b00

Re: [PATCH v4] powerpc: Do not make the entire heap executable

2016-08-19 Thread Denys Vlasenko
On 08/10/2016 03:00 PM, Denys Vlasenko wrote: On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, or with a toolchain which defaults to it) look like this: [17] .sbss NOBITS 0002aff8 01aff8 14 00 WA 0 0 4 [18] .plt NOBITS

Re: [PATCH v4] powerpc: Do not make the entire heap executable

2016-08-10 Thread Oleg Nesterov
On 08/10, Denys Vlasenko wrote: > > Currently, to support 32-bit binaries with PLT in BSS kernel maps *entire > brk area* with executable rights for all binaries, even --secure-plt ones. > > Stop doing that. Can't really review this patch, but at least the change in mm/mmap.c looks technically cor

[PATCH v4] powerpc: Do not make the entire heap executable

2016-08-10 Thread Denys Vlasenko
On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, or with a toolchain which defaults to it) look like this: [17] .sbss NOBITS 0002aff8 01aff8 14 00 WA 0 0 4 [18] .plt NOBITS 0002b00c 01aff8 84 00 WAX 0 0 4 [1