Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-30 Thread Andrew Donnellan
On Tue, 2023-01-24 at 21:47 -0500, Mimi Zohar wrote: > Agreed.  Thank you for the explanation.  To simplify review, I > suggest > either adding this explanation in the patch description or stage the > change by replacing the existing "ibm,edk2-compat-v1" usage first. Will clarify in the commit

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Mimi Zohar
On Wed, 2023-01-25 at 13:23 +1100, Russell Currey wrote: > On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote: > > On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote: > > > From: Russell Currey > > > > > > The secvar object format is only in the device tree under powernv. > > > We now

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Russell Currey
On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote: > On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote: > > From: Russell Currey > > > > The secvar object format is only in the device tree under powernv. > > We now have an API call to retrieve it in a generic way, so we > > should > >

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Andrew Donnellan
On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote: > > -   /* The following only applies for the edk2-compat backend. > > */ > > -   node = of_find_compatible_node(NULL, NULL, "ibm,edk2- > > compat-v1"); > > -   if (!node) > > +   len = secvar_ops->format(buf, 32); > >

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Mimi Zohar
On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote: > From: Russell Currey > > The secvar object format is only in the device tree under powernv. > We now have an API call to retrieve it in a generic way, so we should > use that instead of having to handle the DT here. > > Add support

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-23 Thread Nicholas Piggin
On Fri Jan 20, 2023 at 5:43 PM AEST, Andrew Donnellan wrote: > From: Russell Currey > > The secvar object format is only in the device tree under powernv. > We now have an API call to retrieve it in a generic way, so we should > use that instead of having to handle the DT here. > > Add support

[PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-19 Thread Andrew Donnellan
From: Russell Currey The secvar object format is only in the device tree under powernv. We now have an API call to retrieve it in a generic way, so we should use that instead of having to handle the DT here. Add support for pseries secvar, with the "ibm,plpks-sb-v1" format. The object format is