Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread Aneesh Kumar K.V
David Hildenbrand writes: > On 24.07.23 18:02, Aneesh Kumar K V wrote: >> On 7/24/23 9:11 PM, David Hildenbrand wrote: >>> On 24.07.23 17:16, Aneesh Kumar K V wrote: >>> > > /* >   * In "forced" memmap_on_memory mode, we always align the vmemmap size > up to cover >   *

Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread David Hildenbrand
On 24.07.23 18:02, Aneesh Kumar K V wrote: On 7/24/23 9:11 PM, David Hildenbrand wrote: On 24.07.23 17:16, Aneesh Kumar K V wrote: /*   * In "forced" memmap_on_memory mode, we always align the vmemmap size up to cover   * full pageblocks. That way, we can add memory even if the vmemmap

Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread Aneesh Kumar K V
On 7/24/23 9:11 PM, David Hildenbrand wrote: > On 24.07.23 17:16, Aneesh Kumar K V wrote: > >>> >>> /* >>>   * In "forced" memmap_on_memory mode, we always align the vmemmap size up >>> to cover >>>   * full pageblocks. That way, we can add memory even if the vmemmap size >>> is not properly

Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread David Hildenbrand
On 24.07.23 17:16, Aneesh Kumar K V wrote: /*  * In "forced" memmap_on_memory mode, we always align the vmemmap size up to cover  * full pageblocks. That way, we can add memory even if the vmemmap size is not properly  * aligned, however, we might waste memory.  */ I am finding that

Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread Aneesh Kumar K V
On 7/24/23 8:03 PM, David Hildenbrand wrote: > On 18.07.23 04:44, Aneesh Kumar K.V wrote: >> Add a new kconfig option that can be selected if we want to allow > > That description seems outdated. > Will update >> pageblock alignment by reserving pages in the vmemmap altmap area. >> This

Re: [PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-24 Thread David Hildenbrand
On 18.07.23 04:44, Aneesh Kumar K.V wrote: Add a new kconfig option that can be selected if we want to allow That description seems outdated. pageblock alignment by reserving pages in the vmemmap altmap area. This implies we will be reserving some pages for every memoryblock This also allows

[PATCH v4 4/6] mm/hotplug: Allow pageblock alignment via altmap reservation

2023-07-17 Thread Aneesh Kumar K.V
Add a new kconfig option that can be selected if we want to allow pageblock alignment by reserving pages in the vmemmap altmap area. This implies we will be reserving some pages for every memoryblock This also allows the memmap on memory feature to be widely useful with different memory block size