Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-02-02 Thread kajoljain
Patchset looks goot to me Reviewed-By: Kajol Jain On 1/27/23 05:06, Ian Rogers wrote: > Add an optimization to jevents using the metric code, rewrite metrics > in terms of each other in order to minimize size and improve > readability. For example, on Power8 > other_stall_cpi is rewritten from: >

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-02-01 Thread John Garry
On 31/01/2023 00:39, Ian Rogers wrote: Thanks John, will fix. Is there anything else? Do you think that pmu-events/__pycache__/metric.cpython-36.pyc should be deleted with a make clean? I would expect stuff like this to be deleted (with a clean), but I am not sure if we have a policy on this (py

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-01-30 Thread Ian Rogers
On Mon, Jan 30, 2023 at 7:22 AM John Garry wrote: > > On 27/01/2023 13:48, Ian Rogers wrote: > > On Fri, Jan 27, 2023, 5:20 AM John Garry > > wrote: > > > > On 26/01/2023 23:36, Ian Rogers wrote: > > > > Hi Ian, > > > > At a glance, none of this series

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-01-30 Thread John Garry
On 27/01/2023 13:48, Ian Rogers wrote: On Fri, Jan 27, 2023, 5:20 AM John Garry > wrote: On 26/01/2023 23:36, Ian Rogers wrote: Hi Ian, At a glance, none of this series has your Signed-off-by tag.. Thanks, John Thanks John, will fix. Is t

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-01-27 Thread Ian Rogers
On Fri, Jan 27, 2023, 5:20 AM John Garry wrote: > On 26/01/2023 23:36, Ian Rogers wrote: > > Hi Ian, > > At a glance, none of this series has your Signed-off-by tag.. > > Thanks, > John > Thanks John, will fix. Is there anything else? Ian > Add an optimization to jevents using the metric code

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-01-27 Thread John Garry
On 27/01/2023 13:48, Ian Rogers wrote: On Fri, Jan 27, 2023, 5:20 AM John Garry > wrote: On 26/01/2023 23:36, Ian Rogers wrote: Hi Ian, At a glance, none of this series has your Signed-off-by tag.. Thanks, John Thanks John, will fix. Is t

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-01-27 Thread John Garry
On 26/01/2023 23:36, Ian Rogers wrote: Hi Ian, At a glance, none of this series has your Signed-off-by tag.. Thanks, John Add an optimization to jevents using the metric code, rewrite metrics in terms of each other in order to minimize size and improve readability. For example, on Power8 othe

[PATCH v5 00/15] jevents/pmu-events improvements

2023-01-26 Thread Ian Rogers
Add an optimization to jevents using the metric code, rewrite metrics in terms of each other in order to minimize size and improve readability. For example, on Power8 other_stall_cpi is rewritten from: "PM_CMPLU_STALL / PM_RUN_INST_CMPL - PM_CMPLU_STALL_BRU_CRU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_