Re: [PATCH v5 2/7] perf annotate: Add cross arch annotate support

2016-08-19 Thread Ravi Bangoria
On Friday 19 August 2016 04:18 PM, Russell King - ARM Linux wrote: > On Fri, Aug 19, 2016 at 04:09:51PM +0530, Ravi Bangoria wrote: >> Thanks Russell for reviewing. >> >> On Friday 19 August 2016 01:20 PM, Russell King - ARM Linux wrote: >>> On Fri, Aug 19, 2016 at 10:59:01AM +0530, Ravi

Re: [PATCH v5 2/7] perf annotate: Add cross arch annotate support

2016-08-19 Thread Russell King - ARM Linux
On Fri, Aug 19, 2016 at 04:09:51PM +0530, Ravi Bangoria wrote: > Thanks Russell for reviewing. > > On Friday 19 August 2016 01:20 PM, Russell King - ARM Linux wrote: > > On Fri, Aug 19, 2016 at 10:59:01AM +0530, Ravi Bangoria wrote: > >> -static struct ins instructions[] = { > >> +static struct

Re: [PATCH v5 2/7] perf annotate: Add cross arch annotate support

2016-08-19 Thread Ravi Bangoria
Thanks Russell for reviewing. On Friday 19 August 2016 01:20 PM, Russell King - ARM Linux wrote: > On Fri, Aug 19, 2016 at 10:59:01AM +0530, Ravi Bangoria wrote: >> -static struct ins instructions[] = { >> +static struct ins instructions_x86[] = { >> { .name = "add", .ops = _ops, }, >>

Re: [PATCH v5 2/7] perf annotate: Add cross arch annotate support

2016-08-19 Thread Russell King - ARM Linux
On Fri, Aug 19, 2016 at 10:59:01AM +0530, Ravi Bangoria wrote: > -static struct ins instructions[] = { > +static struct ins instructions_x86[] = { > { .name = "add", .ops = _ops, }, > { .name = "addl", .ops = _ops, }, > { .name = "addq", .ops = _ops, }, > { .name =

[PATCH v5 2/7] perf annotate: Add cross arch annotate support

2016-08-18 Thread Ravi Bangoria
Change current data structures and function to enable cross arch annotate. Current perf implementation does not support cross arch annotate. To make it truly cross arch, instruction table of all arch should be present in perf binary. And use appropriate table based on arch where perf.data was