Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-21 Thread Christophe Leroy
Hi Hervé, Le 18/09/2023 à 09:49, Herve Codina a écrit : > Hi Christophe, > > On Tue, 12 Sep 2023 18:49:26 + > Christophe Leroy wrote: > >> Le 12/09/2023 à 20:13, Conor Dooley a écrit : >>> Yo, >>> >>> I'm not au fait enough with this to leave particularly meaningful >>> comments, so just

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-18 Thread Herve Codina
On Mon, 18 Sep 2023 09:49:19 +0200 Herve Codina wrote: > Hi Christophe, > > On Tue, 12 Sep 2023 18:49:26 + > Christophe Leroy wrote: > > > Le 12/09/2023 à 20:13, Conor Dooley a écrit : > > > Yo, > > > > > > I'm not au fait enough with this to leave particularly meaningful > > >

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-18 Thread Herve Codina
Hi Christophe, On Tue, 12 Sep 2023 18:49:26 + Christophe Leroy wrote: > Le 12/09/2023 à 20:13, Conor Dooley a écrit : > > Yo, > > > > I'm not au fait enough with this to leave particularly meaningful > > comments, so just some minor ones for you. > > > > On Tue, Sep 12, 2023 at 12:14:44PM

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-13 Thread Conor Dooley
On Tue, Sep 12, 2023 at 01:54:05PM -0500, Rob Herring wrote: > > > + lantiq,data-rate-bps: > > > +$ref: /schemas/types.yaml#/definitions/uint32 > > > +enum: [2048000, 4096000, 8192000, 16384000] > > > > -kBps is a standard suffix, would it be worth using that instead here? > > What you

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-12 Thread Rob Herring
On Tue, Sep 12, 2023 at 07:13:32PM +0100, Conor Dooley wrote: > Yo, > > I'm not au fait enough with this to leave particularly meaningful > comments, so just some minor ones for you. > > On Tue, Sep 12, 2023 at 12:14:44PM +0200, Herve Codina wrote: > > The Lantiq PEF2256 is a framer and line

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-12 Thread Christophe Leroy
Le 12/09/2023 à 20:13, Conor Dooley a écrit : > Yo, > > I'm not au fait enough with this to leave particularly meaningful > comments, so just some minor ones for you. > > On Tue, Sep 12, 2023 at 12:14:44PM +0200, Herve Codina wrote: >> The Lantiq PEF2256 is a framer and line interface

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-12 Thread Conor Dooley
Yo, I'm not au fait enough with this to leave particularly meaningful comments, so just some minor ones for you. On Tue, Sep 12, 2023 at 12:14:44PM +0200, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an

[PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-12 Thread Herve Codina
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. Signed-off-by: Herve Codina Signed-off-by: Christophe Leroy --- .../bindings/net/lantiq,pef2256.yaml |