Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-10 Thread Michael Walle
Am 2020-12-10 18:38, schrieb Bjorn Helgaas: On Wed, Dec 09, 2020 at 10:29:04PM +0200, Vladimir Oltean wrote: On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > Hopefully my mail client won't mess up the output that much. I can reproduce on my LS1028A as well. The following fixes

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-10 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 10:29:04PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > > Hopefully my mail client won't mess up the output that much. > > I can reproduce on my LS1028A as well. The following fixes the bug for > me. I did not follow the

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 11:43:59PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 03:34:49PM -0600, Bjorn Helgaas wrote: > > On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > > > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > > > Yep, that's the

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 03:34:49PM -0600, Bjorn Helgaas wrote: > On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > > Yep, that's the theory. Thanks for testing it! > > > > Testing what? I'm not following. > >

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 11:20:17PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > > Yep, that's the theory. Thanks for testing it! > > Testing what? I'm not following. You posted a patch that you said fixed the bug for you. The fix is exactly

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 02:59:13PM -0600, Bjorn Helgaas wrote: > Yep, that's the theory. Thanks for testing it! Testing what? I'm not following.

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 10:29:04PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > > Hopefully my mail client won't mess up the output that much. > > I can reproduce on my LS1028A as well. The following fixes the bug for > me. I did not follow the

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > Hopefully my mail client won't mess up the output that much. I can reproduce on my LS1028A as well. The following fixes the bug for me. I did not follow the discussion and see if it is helpful for others. I don't understand how the

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
Am 2020-12-09 15:57, schrieb Bjorn Helgaas: [..] Can you try the following just to get started? diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 46935695cfb9..569a45727bc7 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -79,6 +79,7 @@ int

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Wed, Dec 09, 2020 at 02:08:00PM +0100, Michael Walle wrote: > [+ Vladimir and Alex] > > Am 2020-12-09 13:36, schrieb Bjorn Helgaas: > > On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: > > > >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > > > >> Unify

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
[+ Vladimir and Alex] Am 2020-12-09 13:36, schrieb Bjorn Helgaas: On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining memory address

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Bjorn Helgaas
On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: > >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > >> Unify ECAM-related constants into a single set of standard constants > >> defining memory address shift values for the byte-level address that can > >> be used

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Michael Walle
Am 2020-12-08 22:06, schrieb Bjorn Helgaas: [+cc Qian] On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: Hi Lorenzo, Krzysztof, >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Bjorn Helgaas
[+cc Qian] On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: > Hi Lorenzo, Krzysztof, > > >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > >> Unify ECAM-related constants into a single set of standard constants > >> defining memory address shift values for the

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Qian Cai
On Sun, 2020-11-29 at 23:07 +, Krzysztof Wilczyński wrote: > Unify ECAM-related constants into a single set of standard constants > defining memory address shift values for the byte-level address that can > be used when accessing the PCI Express Configuration Space, and then > move native PCI

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Michael Walle
Hi Lorenzo, Krzysztof, >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining memory address shift values for the byte-level address that can >> be used when accessing the PCI Express Configuration

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-01 Thread Lorenzo Pieralisi
On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: > Unify ECAM-related constants into a single set of standard constants > defining memory address shift values for the byte-level address that can > be used when accessing the PCI Express Configuration Space, and then > move native PCI

[PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-11-29 Thread Krzysztof Wilczyński
Unify ECAM-related constants into a single set of standard constants defining memory address shift values for the byte-level address that can be used when accessing the PCI Express Configuration Space, and then move native PCI Express controller drivers to use newly introduced definitions retiring