[PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2013 at 8:01 AM, Peter Chen peter.c...@freescale.com wrote: /* make sure USB_CLK is running at 60 MHz +/- 1000 Hz */ - if (!cpu_is_mx51()) { + if (!strcmp(pdev-id_entry-name, imx-udc-mx27)) {]] Shouldn't this be: if (!strcmp(pdev-id_entry-name,

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Lothar Waßmann
Hi, Fabio Estevam writes: On Thu, Jan 17, 2013 at 8:01 AM, Peter Chen peter.c...@freescale.com wrote: /* make sure USB_CLK is running at 60 MHz +/- 1000 Hz */ - if (!cpu_is_mx51()) { + if (!strcmp(pdev-id_entry-name, imx-udc-mx27)) {]] Shouldn't this be: if

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann l...@karo-electronics.de wrote: The equivalent of !cpu_is_mx51() would be strcmp(pdev-id_entry-name, imx-udc-mx51) (without the '!') meaning id_entry-name is different from imx-udc-mx51. Yes, agree. strcmp(pdev-id_entry-name, imx-udc-mx51) is

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
On Thu, Jan 17, 2013 at 12:43:23PM -0200, Fabio Estevam wrote: On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann l...@karo-electronics.de wrote: The equivalent of !cpu_is_mx51() would be strcmp(pdev-id_entry-name, imx-udc-mx51) (without the '!') meaning id_entry-name is different from