Re: [PATCH v7 21/25] Kbuild: add Rust support

2022-07-16 Thread Miguel Ojeda
Hi Masahiro, On Sat, Jul 16, 2022 at 10:23 AM Masahiro Yamada wrote: > > Is it intentional to print the successful message to stderr? I think it makes sense to change it to `stdout`, given the message is the main point of running `rustavailable` for normal users, and those that just want the

Re: [PATCH v7 21/25] Kbuild: add Rust support

2022-07-16 Thread Masahiro Yamada
On Mon, May 23, 2022 at 11:04 AM Miguel Ojeda wrote: > > Having all the new files in place, we now enable Rust support > in the build system, including `Kconfig` entries related to Rust, > the Rust configuration printer, the target specification > generation script, the version detection script

Re: [PATCH v7 21/25] Kbuild: add Rust support

2022-05-30 Thread Miguel Ojeda
On Thu, May 26, 2022 at 12:25 AM Nick Desaulniers wrote: > > Is there a reason to not just turn clippy on always? Might be nicer to > start off with good practices by default. :^) The idea crossed my mind too [1], but sadly Clippy disables some optimizations and in general is not intended to be

Re: [PATCH v7 21/25] Kbuild: add Rust support

2022-05-24 Thread Miguel Ojeda
On Mon, May 23, 2022 at 8:45 PM Nick Desaulniers wrote: > > I'm super not into having the rust optimization level differ from the > C optimization level. This is just someone having too much fun > wrapping every compiler flag in a kbuild option. Either folks wan't I mean, `Makefile`s are not

[PATCH v7 21/25] Kbuild: add Rust support

2022-05-22 Thread Miguel Ojeda
Having all the new files in place, we now enable Rust support in the build system, including `Kconfig` entries related to Rust, the Rust configuration printer, the target specification generation script, the version detection script and a few other bits. Co-developed-by: Alex Gaynor