Re: [PATCH v7 3/6] perf/tools: Refactoring metricgroup__add_metric function

2020-03-30 Thread Jiri Olsa
On Fri, Mar 27, 2020 at 03:55:25PM +0530, Kajol Jain wrote: SNIP > + eg->ids = ids; > + eg->idnum = idnum; > + eg->metric_name = pe->metric_name; > + eg->metric_expr = pe->metric_expr; > + eg->metric_unit = pe->unit; > + list_add_tail(&eg->nd, group_list); > + > + retu

Re: [PATCH v7 3/6] perf/tools: Refactoring metricgroup__add_metric function

2020-03-30 Thread Jiri Olsa
On Fri, Mar 27, 2020 at 03:55:25PM +0530, Kajol Jain wrote: > This patch refactor metricgroup__add_metric function where > some part of it move to function metricgroup__add_metric_param. > No logic change. > > Signed-off-by: Kajol Jain > --- > tools/perf/util/metricgroup.c | 61 +

[PATCH v7 3/6] perf/tools: Refactoring metricgroup__add_metric function

2020-03-27 Thread Kajol Jain
This patch refactor metricgroup__add_metric function where some part of it move to function metricgroup__add_metric_param. No logic change. Signed-off-by: Kajol Jain --- tools/perf/util/metricgroup.c | 61 +-- 1 file changed, 36 insertions(+), 25 deletions(-) dif