Re: [PATCH v8 2/6] powerpc/code-patching: Use WARN_ON and fix check in poking_init

2022-10-23 Thread Russell Currey
On Fri, 2022-10-21 at 16:22 +1100, Benjamin Gray wrote: > From: "Christopher M. Riedl" > > The latest kernel docs list BUG_ON() as 'deprecated' and that they > should be replaced with WARN_ON() (or pr_warn()) when possible. The > BUG_ON() in poking_init() warrants a WARN_ON() rather than a >

[PATCH v8 2/6] powerpc/code-patching: Use WARN_ON and fix check in poking_init

2022-10-20 Thread Benjamin Gray
From: "Christopher M. Riedl" The latest kernel docs list BUG_ON() as 'deprecated' and that they should be replaced with WARN_ON() (or pr_warn()) when possible. The BUG_ON() in poking_init() warrants a WARN_ON() rather than a pr_warn() since the error condition is deemed "unreachable". Also take