Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2019-01-08 Thread Finn Thain
On Tue, 8 Jan 2019, Michael Ellerman wrote: > > The reason why that doesn't work boils down to introspection. (This > > was mentioned elsewhere in this email thread.) For example, we > > presently have code like this, > > > > ssize_t nvram_get_size(void) > > { > >if (ppc_md.nvram_size)

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2019-01-08 Thread Michael Ellerman
Finn Thain writes: > On Mon, 7 Jan 2019, Michael Ellerman wrote: > >> Arnd Bergmann writes: >> > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain >> > wrote: >> > >> >> +static ssize_t ppc_nvram_get_size(void) >> >> +{ >> >> + if (ppc_md.nvram_size) >> >> + return

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2019-01-06 Thread Finn Thain
On Mon, 7 Jan 2019, Michael Ellerman wrote: > Arnd Bergmann writes: > > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain > > wrote: > > > >> +static ssize_t ppc_nvram_get_size(void) > >> +{ > >> + if (ppc_md.nvram_size) > >> + return ppc_md.nvram_size(); > >> + return

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2019-01-06 Thread Michael Ellerman
Arnd Bergmann writes: > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain wrote: > >> +static ssize_t ppc_nvram_get_size(void) >> +{ >> + if (ppc_md.nvram_size) >> + return ppc_md.nvram_size(); >> + return -ENODEV; >> +} > >> +const struct nvram_ops arch_nvram_ops = { >> +

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2019-01-04 Thread Finn Thain
On Mon, 31 Dec 2018, Arnd Bergmann wrote: > On Sun, Dec 30, 2018 at 4:29 AM Finn Thain wrote: > > > > On Sat, 29 Dec 2018, Arnd Bergmann wrote: > > > > > With the current method, it does seem odd to have a single > > > per-architecture instance of the exported structure containing > > >

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2018-12-31 Thread Finn Thain
On Mon, 31 Dec 2018, Arnd Bergmann wrote: > On Sun, Dec 30, 2018 at 4:29 AM Finn Thain wrote: > > > > On Sat, 29 Dec 2018, Arnd Bergmann wrote: > > > > > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain > > > wrote: > > > > > > > +static ssize_t ppc_nvram_get_size(void) > > > > +{ > > > > + if

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2018-12-31 Thread Arnd Bergmann
On Sun, Dec 30, 2018 at 4:29 AM Finn Thain wrote: > > On Sat, 29 Dec 2018, Arnd Bergmann wrote: > > > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain > > wrote: > > > > > +static ssize_t ppc_nvram_get_size(void) > > > +{ > > > + if (ppc_md.nvram_size) > > > + return

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2018-12-29 Thread Finn Thain
On Sat, 29 Dec 2018, Arnd Bergmann wrote: > On Wed, Dec 26, 2018 at 1:43 AM Finn Thain wrote: > > > +static ssize_t ppc_nvram_get_size(void) > > +{ > > + if (ppc_md.nvram_size) > > + return ppc_md.nvram_size(); > > + return -ENODEV; > > +} > > > +const struct

Re: [PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2018-12-29 Thread Arnd Bergmann
On Wed, Dec 26, 2018 at 1:43 AM Finn Thain wrote: > +static ssize_t ppc_nvram_get_size(void) > +{ > + if (ppc_md.nvram_size) > + return ppc_md.nvram_size(); > + return -ENODEV; > +} > +const struct nvram_ops arch_nvram_ops = { > + .read =

[PATCH v8 24/25] powerpc: Adopt nvram module for PPC64

2018-12-25 Thread Finn Thain
Adopt nvram module to reduce code duplication. This means CONFIG_NVRAM becomes available to CONFIG_PPC64 builds (until now it was only PPC32). The IOC_NVRAM_GET_OFFSET ioctl as implemented on PPC64 validates the offset returned by pmac_get_partition(). Add this test to the nvram module. Note