Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-31 Thread Mark Brown
On Fri, May 31, 2024 at 10:48:12AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > So you're trying to use this as the audio clock? There's no code that > > enables the clock which seems worrying, and I'd expect that if the > > device is using it's own clock the device would be

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-31 Thread Elinor Montmasson
From: "Mark Brown" Sent: Friday, 31 May, 2024 15:05:28 > On Fri, May 31, 2024 at 08:46:55AM -0400, Elinor Montmasson wrote: >> From: "Mark Brown" >> > On Fri, May 17, 2024 at 05:05:35AM -0400, Elinor Montmasson wrote: >> >> From: "Mark Brown" >> >> > On Wed, May 15, 2024 at 03:54:09PM +0200,

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-31 Thread Mark Brown
On Fri, May 31, 2024 at 08:46:55AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > On Fri, May 17, 2024 at 05:05:35AM -0400, Elinor Montmasson wrote: > >> From: "Mark Brown" > >> > On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > >> >> + struct clk

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-31 Thread Elinor Montmasson
From: "Mark Brown" Sent: Friday, 17 May, 2024 13:17:20 > On Fri, May 17, 2024 at 05:05:35AM -0400, Elinor Montmasson wrote: >> From: "Mark Brown" >> > On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > >> >> + struct clk *cpu_sysclk = clk_get(>dev, "cpu_sysclk"); >> >>

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-17 Thread Mark Brown
On Fri, May 17, 2024 at 05:05:35AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > >> + struct clk *cpu_sysclk = clk_get(>dev, "cpu_sysclk"); > >> + if (!IS_ERR(cpu_sysclk)) { > >> +

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-17 Thread Elinor Montmasson
From: "Mark Brown" Sent: Thursday, 16 May, 2024 14:13:19 > On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > >> Add an optional DT clock "cpu_sysclk" to get the CPU DAI system-clock >> frequency when using the generic codec. >> It is set for both Tx and Rx. >> The way the

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-16 Thread Mark Brown
On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > Add an optional DT clock "cpu_sysclk" to get the CPU DAI system-clock > frequency when using the generic codec. > It is set for both Tx and Rx. > The way the frequency value is used is up to the CPU DAI driver > implementation.

[PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-15 Thread Elinor Montmasson
Add an optional DT clock "cpu_sysclk" to get the CPU DAI system-clock frequency when using the generic codec. It is set for both Tx and Rx. The way the frequency value is used is up to the CPU DAI driver implementation. Signed-off-by: Elinor Montmasson --- sound/soc/fsl/fsl-asoc-card.c | 6