Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-06-06 Thread Elinor Montmasson
> From: "Mark Brown" > Sent: Friday, 31 May, 2024 18:06:30 > On Fri, May 31, 2024 at 10:48:14AM -0400, Elinor Montmasson wrote: >> From: "Mark Brown" > >> > Why not just use the existing compatible - why would someone not want to >> > be able to use the ASRC if it's available in their system?

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-31 Thread Mark Brown
On Fri, May 31, 2024 at 10:48:14AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > Why not just use the existing compatible - why would someone not want to > > be able to use the ASRC if it's available in their system? > That's true but it will be a problem if both `fsl-asoc-card.c`

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-31 Thread Elinor Montmasson
From: "Mark Brown" Sent: Friday, 31 May, 2024 15:14:13 > On Fri, May 31, 2024 at 08:48:04AM -0400, Elinor Montmasson wrote: > >> Then maybe it's not be a good idea to make this compatible generic >> for this contribution. >> The original intention is to bring support for the S/PDIF, >> so maybe

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-31 Thread Mark Brown
On Fri, May 31, 2024 at 08:48:04AM -0400, Elinor Montmasson wrote: > Then maybe it's not be a good idea to make this compatible generic > for this contribution. > The original intention is to bring support for the S/PDIF, > so maybe the contribution should focus on this use case? > In that case,

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-31 Thread Elinor Montmasson
From: "Rob Herring" Sent: Monday, 20 May, 2024 20:31:48 > On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: >> Add documentation about new dts bindings following new support >> for compatible "fsl,imx-audio-generic". >> >> Some CPU DAI don't require a real audio codec. The new

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-31 Thread Elinor Montmasson
From: "Mark Brown" Sent: Friday, 17 May, 2024 13:11:43 > On Fri, May 17, 2024 at 05:05:41AM -0400, Elinor Montmasson wrote: >> From: "Mark Brown" > >> > This description (and the code) don't feel like they're actually generic >> > - they're clearly specific to the bidrectional S/PDIF case. I'd

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-20 Thread Rob Herring
On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > Add documentation about new dts bindings following new support > for compatible "fsl,imx-audio-generic". > > Some CPU DAI don't require a real audio codec. The new compatible > "fsl,imx-audio-generic" allows using the driver

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-17 Thread Mark Brown
On Fri, May 17, 2024 at 05:05:41AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > This description (and the code) don't feel like they're actually generic > > - they're clearly specific to the bidrectional S/PDIF case. I'd expect > > something called -generic to cope with single

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-17 Thread Elinor Montmasson
From: "Mark Brown" Sent: Thursday, 16 May, 2024 14:11:11 > On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > >> Add documentation about new dts bindings following new support >> for compatible "fsl,imx-audio-generic". > >>audio-codec: >> -$ref:

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-16 Thread Mark Brown
On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > Add documentation about new dts bindings following new support > for compatible "fsl,imx-audio-generic". >audio-codec: > -$ref: /schemas/types.yaml#/definitions/phandle > -description: The phandle of an audio codec

[PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-15 Thread Elinor Montmasson
Add documentation about new dts bindings following new support for compatible "fsl,imx-audio-generic". Some CPU DAI don't require a real audio codec. The new compatible "fsl,imx-audio-generic" allows using the driver with codec drivers SPDIF DIT and SPDIF DIR as dummy codecs. It also allows using