Re: [RFC/PATCH] Implement {read,update}_persistent_clock. v2

2007-09-11 Thread Tony Breeds
On Tue, Sep 11, 2007 at 09:34:13AM -0500, Milton Miller wrote: > Previously we called ppc_md.get_boot_time at most once. How about > moving the check for it into the if (first) block? Yup on investigatiion it looks like moving it inside the "if (fist)" is safe. > Have you tested with a platf

Re: [RFC/PATCH] Implement {read,update}_persistent_clock. v2

2007-09-11 Thread Milton Miller
On Tue Sep 11 18:17:46 EST 2007, Tony Breeds wrote: > +unsigned long read_persistent_clock(void) > { > struct rtc_time tm; > + static int first = 1; > + > + if (first) { > + first = 0; > + if (ppc_md.time_init) > + timezone_offs

Re: [RFC/PATCH] Implement {read,update}_persistent_clock.

2007-09-11 Thread Gabriel Paubert
On Tue, Sep 11, 2007 at 05:49:17PM +1000, Tony Breeds wrote: > With these functions implemented we cooperate better with the generic > timekeeping code. This obsoletes the need for the timer sysdev as a bonus. Looks fine, there is still the problem that most PPC RTC seem to prefer update on the s

Re: [RFC/PATCH] Implement {read,update}_persistent_clock. v2

2007-09-11 Thread Tony Breeds
From: Tony Breeds <[EMAIL PROTECTED]> Implement {read,update}_persistent_clock. With these functions implemented we cooperate better with the generic timekeeping code. This obsoletes the need for the timer sysdev as a bonus. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- Functionally is t

[RFC/PATCH] Implement {read,update}_persistent_clock.

2007-09-11 Thread Tony Breeds
With these functions implemented we cooperate better with the generic timekeeping code. This obsoletes the need for the timer sysdev as a bonus. Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- * Compile tested for arch/powerpc/configs/*_defconfig * Booted on pSeries, iSeries, Cell and PS3 *