Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-07 Thread Segher Boessenkool
The hardware should be described in the device tree. This isn't the same as simply copying all your Linux code into it ;-) >>> >>> Ugh. SD/MMC slot is the hardware, isn't it? It have wired SPI pins, >>> and chip select pin. To set up this pin, I need mmc node, which means >>> that I can'

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-07 Thread Anton Vorontsov
On Mon, Aug 06, 2007 at 08:18:47PM +0200, Segher Boessenkool wrote: [...] >>> The hardware should be described in the device tree. This isn't >>> the same as simply copying all your Linux code into it ;-) >> >> Ugh. SD/MMC slot is the hardware, isn't it? It have wired SPI pins, >> and chip select

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Segher Boessenkool
>>> + max-speed-hz = ; /* 1250 Hz >>> */ Just max-speed. >>> >>> Segher, how is this different from: >>> >>> http://ozlabs.org/pipermail/linuxppc-dev/2007-April/034557.html >> >> Not sure what you mean. I'm just saying that "speed-hz" is a >> te

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Kim Phillips
On Mon, 6 Aug 2007 20:25:13 +0200 Segher Boessenkool <[EMAIL PROTECTED]> wrote: > > + max-speed-hz = ; /* 1250 Hz > > */ > >> > >> Just max-speed. > > > > Segher, how is this different from: > > > > http://ozlabs.org/pipermail/linuxppc-dev/2007-April/0345

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Scott Wood
Segher Boessenkool wrote: >>p.s. mpc8272ads.dts is broken wrt spaces/tabs, very. > > > Care to do a cleanup patch? Good for your karma ;-) I've got one in my 82xx patchset (a respin of which should be coming soon). There's a lot more broken in there than just spaces/tabs, BTW. :-) -Scott

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Segher Boessenkool
> + max-speed-hz = ; /* 1250 Hz */ >> >> Just max-speed. > > Segher, how is this different from: > > http://ozlabs.org/pipermail/linuxppc-dev/2007-April/034557.html Not sure what you mean. I'm just saying that "speed-hz" is a terrible name, I'm not saying that "max

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Segher Boessenkool
>> For some buses, there is a "slot-names" property; some (non-core) >> bindings seem to define a "location" property. >> For "random" human-readable labelling, i.e. not corresponding to >> physical markings on the hardware, I recommend you look for a >> matching entry in /aliases. > > Aliases coul

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Segher Boessenkool
> [EMAIL PROTECTED] { > device_type = "spi"; > + device-id = <1>; Can we just use the reg value for bus_num in the kernel. >>> >>> Sure, technically nothing prevents this. But, QE specs names >>> SPIs by these ids. >> >> As a minimum

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-06 Thread Segher Boessenkool
>>> + spi1pio:[EMAIL PROTECTED] { >> >> There should be whitespace after the label. @01 should be >> spelled @1. Except there is no "reg" property. > > Hm. I've just tried to keep original style in this particular dts. > Want to ack patch below? Not unless you get rid of the ex

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-01 Thread Kim Phillips
On Wed, 1 Aug 2007 00:06:46 +0200 Segher Boessenkool <[EMAIL PROTECTED]> wrote: > >>> + max-speed-hz = ; /* 1250 Hz */ > > Just max-speed. Segher, how is this different from: http://ozlabs.org/pipermail/linuxppc-dev/2007-April/034557.html ? Kim

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-01 Thread Scott Wood
Segher Boessenkool wrote: > For some buses, there is a "slot-names" property; some (non-core) > bindings seem to define a "location" property. > > For "random" human-readable labelling, i.e. not corresponding to > physical markings on the hardware, I recommend you look for a > matching entry in /a

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-01 Thread Anton Vorontsov
On Wed, Aug 01, 2007 at 12:06:46AM +0200, Segher Boessenkool wrote: [EMAIL PROTECTED] { device_type = "spi"; + device-id = <1>; >>> >>> Can we just use the reg value for bus_num in the kernel. >> >> Sure, technically nothing prevents thi

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-01 Thread Anton Vorontsov
On Wed, Aug 01, 2007 at 12:10:28AM +0200, Segher Boessenkool wrote: >> +spi1pio:[EMAIL PROTECTED] { > > There should be whitespace after the label. @01 should be > spelled @1. Except there is no "reg" property. Hm. I've just tried to keep original style in this particular dts

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-31 Thread Segher Boessenkool
> + spi1pio:[EMAIL PROTECTED] { There should be whitespace after the label. @01 should be spelled @1. Except there is no "reg" property. What is this stuff, anyway? > + pio-map = < > + /* port pin dir open_drain assignment

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-31 Thread Segher Boessenkool
>>> [EMAIL PROTECTED] { >>> device_type = "spi"; >>> + device-id = <1>; >> >> Can we just use the reg value for bus_num in the kernel. > > Sure, technically nothing prevents this. But, QE specs names > SPIs by these ids. As a minimum the property n

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-31 Thread Segher Boessenkool
> Naming devices for human consumption is a more general problem than > device-id addresses; I'd like to see a standard "label" property added > to > the device tree spec that software could use to present a > human-friendly > label that corresponds to markings on the case, position on the board,

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Scott Wood
On Fri, Jul 27, 2007 at 03:45:59PM +0400, Anton Vorontsov wrote: > Sure, technically nothing prevents this. But, QE specs names > SPIs by these ids. Plus, from the kernel side spi name will be > not pretty, it will be spi1216.1. Reg value making little sense > to the userspace (or kernel-side SPI l

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Kumar Gala
On Jul 27, 2007, at 6:45 AM, Anton Vorontsov wrote: > On Fri, Jul 27, 2007 at 03:14:06AM -0500, Kumar Gala wrote: >> >> On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote: > [...] >>> >>> @@ -207,20 +222,36 @@ >>> >>> [EMAIL PROTECTED] { >>> device_type = "spi"; >>

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Anton Vorontsov
On Fri, Jul 27, 2007 at 03:14:06AM -0500, Kumar Gala wrote: > > On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote: [...] >> >> @@ -207,20 +222,36 @@ >> >> [EMAIL PROTECTED] { >> device_type = "spi"; >> +device-id = <1>; > > Can we just use the

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote: > mmc_spi already tested to work. When it will hit mainline > the only change that would be needed is replacing "spidev" > by "mmc_spi", and adding trivial platform data to mmc_spi > driver. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-26 Thread Anton Vorontsov
On Thu, Jul 26, 2007 at 05:36:06PM +0200, Joakim Tjernlund wrote: [...] > > [EMAIL PROTECTED] { > > device_type = "spi"; > > + device-id = <1>; > > compatible = "fsl_spi"; > > reg = <4c0 40>; > >

RE: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-26 Thread Joakim Tjernlund
> -Original Message- > From: > [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > abs.org] On Behalf Of Anton Vorontsov > Sent: den 26 juli 2007 15:58 > To: linuxppc-dev@ozlabs.org > Subject: [RFC][PATCH] MPC832x_RDB: update dts to use spi, > register mmc_sp

[RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-26 Thread Anton Vorontsov
mmc_spi already tested to work. When it will hit mainline the only change that would be needed is replacing "spidev" by "mmc_spi", and adding trivial platform data to mmc_spi driver. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc832x_rdb.dts | 33 ++