Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Benjamin Herrenschmidt
On Wed, 2010-04-07 at 10:27 +0530, Vaidyanathan Srinivasan wrote: > > Check the result. Also that's not a nice way to do that, you should look > > for /cpus by path I reckon. > > I will check the return code, but why do you feel getting the node by > path is better? Is there any race, or we may

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Vaidyanathan Srinivasan
* Benjamin Herrenschmidt [2010-04-07 12:04:49]: > On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: > > Hi, > > > diff --git a/arch/powerpc/kernel/setup-common.c > > b/arch/powerpc/kernel/setup-common.c > > index 03dd6a2..fbd93e3 100644 > > --- a/arch/powerpc/kernel/setup-common

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-04-06 Thread Benjamin Herrenschmidt
On Wed, 2010-03-03 at 23:48 +0530, Vaidyanathan Srinivasan wrote: > Hi, > diff --git a/arch/powerpc/kernel/setup-common.c > b/arch/powerpc/kernel/setup-common.c > index 03dd6a2..fbd93e3 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -359,6 +359,8

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-09 Thread Vaidyanathan Srinivasan
* Dipankar Sarma [2010-03-09 00:58:26]: > On Mon, Mar 08, 2010 at 12:20:06PM +0530, Vaidyanathan Srinivasan wrote: > > * Dipankar Sarma [2010-03-06 00:48:11]: > > > > > Shouldn't we create this only for supported platforms ? > > > > Hi Dipankar, > > > > Yes we will need a check like > > firmw

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-08 Thread Dipankar Sarma
On Mon, Mar 08, 2010 at 12:20:06PM +0530, Vaidyanathan Srinivasan wrote: > * Dipankar Sarma [2010-03-06 00:48:11]: > > > Shouldn't we create this only for supported platforms ? > > Hi Dipankar, > > Yes we will need a check like > firmware_has_feature(FW_FEATURE_BEST_ENERGY) to avoid sysfs files

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-07 Thread Vaidyanathan Srinivasan
* Dipankar Sarma [2010-03-06 00:48:11]: > On Wed, Mar 03, 2010 at 11:48:22PM +0530, Vaidyanathan Srinivasan wrote: > > static void __init cpu_init_thread_core_maps(int tpc) > > diff --git a/arch/powerpc/platforms/pseries/Kconfig > > b/arch/powerpc/platforms/pseries/Kconfig > > index c667f0f..b3

Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-05 Thread Dipankar Sarma
On Wed, Mar 03, 2010 at 11:48:22PM +0530, Vaidyanathan Srinivasan wrote: > static void __init cpu_init_thread_core_maps(int tpc) > diff --git a/arch/powerpc/platforms/pseries/Kconfig > b/arch/powerpc/platforms/pseries/Kconfig > index c667f0f..b3dd108 100644 > --- a/arch/powerpc/platforms/pseries/

[RFC] powerpc: add support for new hcall H_BEST_ENERGY

2010-03-03 Thread Vaidyanathan Srinivasan
Hi, A new hypervisor call H_BEST_ENERGY is supported in IBM pseries ppc64 platform in order to exports platform energy management capabilities to user space administrative tools. This hypervisor calls provides hints or suggested list of cpus to activate or deactivate for optimized energy manageme