Re: [RFC PATCH] Replaces long number representation by BIT() macro

2019-07-07 Thread Michael Ellerman
Segher Boessenkool writes: > On Tue, Jul 02, 2019 at 11:16:35AM -0500, Segher Boessenkool wrote: >> On Wed, Jul 03, 2019 at 01:19:34AM +1000, Michael Ellerman wrote: >> > What we could do is switch to the `UL` macro from include/linux/const.h, >> > rather than using our own ASM_CONST. >> >> You

Re: [RFC PATCH] Replaces long number representation by BIT() macro

2019-07-02 Thread Segher Boessenkool
On Tue, Jul 02, 2019 at 11:16:35AM -0500, Segher Boessenkool wrote: > On Wed, Jul 03, 2019 at 01:19:34AM +1000, Michael Ellerman wrote: > > What we could do is switch to the `UL` macro from include/linux/const.h, > > rather than using our own ASM_CONST. > > You need gas 2.28 or later for that

Re: [RFC PATCH] Replaces long number representation by BIT() macro

2019-07-02 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 01:19:34AM +1000, Michael Ellerman wrote: > What we could do is switch to the `UL` macro from include/linux/const.h, > rather than using our own ASM_CONST. You need gas 2.28 or later for that though. https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=86b80085

Re: [RFC PATCH] Replaces long number representation by BIT() macro

2019-07-02 Thread Michael Ellerman
Hi Leonardo, Leonardo Bras writes: > The main reason of this change is to make these bitmasks more readable. > > The macro ASM_CONST() just appends an UL to it's parameter, so it can be > easily replaced by BIT_MASK, that already uses a UL representation. > > ASM_CONST() in this file may behave

Re: [RFC PATCH] Replaces long number representation by BIT() macro

2019-06-13 Thread Leonardo Bras
Sorry, there is a typo on my commit message. 's/BIT_MASK/BIT/' On Thu, 2019-06-13 at 15:02 -0300, Leonardo Bras wrote: > The main reason of this change is to make these bitmasks more readable. > > The macro ASM_CONST() just appends an UL to it's parameter, so it can be > easily replaced by

[RFC PATCH] Replaces long number representation by BIT() macro

2019-06-13 Thread Leonardo Bras
The main reason of this change is to make these bitmasks more readable. The macro ASM_CONST() just appends an UL to it's parameter, so it can be easily replaced by BIT_MASK, that already uses a UL representation. ASM_CONST() in this file may behave different if __ASSEMBLY__ is defined, as it is