Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-26 Thread Naveen N. Rao
Peter Zijlstra wrote: On Tue, May 24, 2022 at 04:01:48PM +0530, Naveen N. Rao wrote: We need to know for sure either way. Nop'ing out the _mcount locations at boot allows us to discover existing long branch trampolines. If we want to avoid it, we need to note down those locations during build

Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-25 Thread Peter Zijlstra
On Tue, May 24, 2022 at 04:01:48PM +0530, Naveen N. Rao wrote: > We need to know for sure either way. Nop'ing out the _mcount locations at > boot allows us to discover existing long branch trampolines. If we want to > avoid it, we need to note down those locations during build time. > > Do you

Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-24 Thread Naveen N. Rao
Christophe Leroy wrote: Le 24/05/2022 à 12:15, Naveen N. Rao a écrit : Christophe Leroy wrote: Le 23/05/2022 à 19:55, Sathvika Vasireddy a écrit : Architectures can select HAVE_NOP_MCOUNT if they choose to nop out mcount call sites. If that config option is selected, then --mnop is passed

Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-24 Thread Christophe Leroy
Le 24/05/2022 à 12:15, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> >> >> Le 23/05/2022 à 19:55, Sathvika Vasireddy a écrit : >>> Architectures can select HAVE_NOP_MCOUNT if they choose >>> to nop out mcount call sites. If that config option is >>> selected, then --mnop is passed as an

Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-24 Thread Naveen N. Rao
Christophe Leroy wrote: Le 23/05/2022 à 19:55, Sathvika Vasireddy a écrit : Architectures can select HAVE_NOP_MCOUNT if they choose to nop out mcount call sites. If that config option is selected, then --mnop is passed as an option to objtool, along with --mcount. Is there a reason not to

Re: [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-24 Thread Christophe Leroy
Le 23/05/2022 à 19:55, Sathvika Vasireddy a écrit : > Architectures can select HAVE_NOP_MCOUNT if they choose > to nop out mcount call sites. If that config option is > selected, then --mnop is passed as an option to objtool, > along with --mcount. > Is there a reason not to nop out mcount

[RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount

2022-05-23 Thread Sathvika Vasireddy
Architectures can select HAVE_NOP_MCOUNT if they choose to nop out mcount call sites. If that config option is selected, then --mnop is passed as an option to objtool, along with --mcount. Also, make sure that --mnop can be passed as an option to objtool only when --mcount is passed.