Re: [RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

2008-10-16 Thread Alan Cox
> For my network-based hvc backend, a tty_hangup() is caused by a disconnect. If it is network backed then you probably do want TTY_DRIVER_TERMIOS_RESET. For a normal serial type port getty is supposed to sort the terminal settings out. So in your case it sounds like resetting it is the right thin

Re: [RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

2008-10-16 Thread Hendrik Brueckner
Hello, for the sake of completion, here are few more details why I have suggest to add the TTY_DRIVER_RESET_TERMIOS flag: On Tue, Oct 14, 2008 at 10:40:25AM +0100, Alan Cox wrote: > On Tue, 14 Oct 2008 11:12:49 +0200 > Hendrik Brueckner <[EMAIL PROTECTED]> wrote: > > > After a tty hangup() or cl

[RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

2008-10-14 Thread Hendrik Brueckner
From: Hendrik Brueckner <[EMAIL PROTECTED]> After a tty hangup() or close() operation, processes might not reset the termio settings to a sane state. In order to reset the termios to its default settings the tty driver flag TTY_DRIVER_RESET_TERMIOS has been added. TTY driver flag description from

Re: [RFC PATCH 2/5] hvc_console: Add tty driver flag TTY_DRIVER_RESET_TERMIOS

2008-10-14 Thread Alan Cox
On Tue, 14 Oct 2008 11:12:49 +0200 Hendrik Brueckner <[EMAIL PROTECTED]> wrote: > From: Hendrik Brueckner <[EMAIL PROTECTED]> > > After a tty hangup() or close() operation, processes might not reset the > termio settings to a sane state. That is the job of the getty task normally. pty is special