Re: [UPDATED] [PATCH v4 3/7] [ppc] Process dynamic relocations for kernel

2011-12-12 Thread Suzuki Poulose
On 12/11/11 01:32, Segher Boessenkool wrote: Hi Suzuki, Looks quite good, a few comments... +get_type: + /* r4 holds the relocation type */ + extrwi r4, r4, 8, 24 /* r4 = ((char*)r4)[3] */ This comment is confusing (only makes sense together with the lwz a long way up). Agree, will fix

Re: [UPDATED] [PATCH v4 3/7] [ppc] Process dynamic relocations for kernel

2011-12-10 Thread Segher Boessenkool
Hi Suzuki, Looks quite good, a few comments... +get_type: + /* r4 holds the relocation type */ + extrwi r4, r4, 8, 24 /* r4 = ((char*)r4)[3] */ This comment is confusing (only makes sense together with the lwz a long way up). +nxtrela: + /* +* We have to flush

[UPDATED] [PATCH v4 3/7] [ppc] Process dynamic relocations for kernel

2011-12-09 Thread Suzuki K. Poulose
The following patch implements the dynamic relocation processing for PPC32 kernel. relocate() accepts the target virtual address and relocates the kernel image to the same. Currently the following relocation types are handled : R_PPC_RELATIVE R_PPC_ADDR16_LO