Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-08 Thread Eric Dumazet
On Fri, Oct 6, 2023 at 8:52 PM Christian Marangi wrote: > > On Thu, Oct 05, 2023 at 06:41:03PM +0200, Eric Dumazet wrote: > > On Thu, Oct 5, 2023 at 6:32 PM Jakub Kicinski wrote: > > > > > > On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote: > > > > OK, but I suspect some users of

Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-07 Thread Christian Marangi
On Thu, Oct 05, 2023 at 06:41:03PM +0200, Eric Dumazet wrote: > On Thu, Oct 5, 2023 at 6:32 PM Jakub Kicinski wrote: > > > > On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote: > > > OK, but I suspect some users of napi_reschedule() might not be > > > race-free... > > > > What's the race

Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-05 Thread Eric Dumazet
On Thu, Oct 5, 2023 at 6:32 PM Jakub Kicinski wrote: > > On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote: > > OK, but I suspect some users of napi_reschedule() might not be race-free... > > What's the race you're thinking of? This sort of thing... the race is in fl_starving() though...

Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-05 Thread Jakub Kicinski
On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote: > OK, but I suspect some users of napi_reschedule() might not be race-free... What's the race you're thinking of?

Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-05 Thread Eric Dumazet
On Tue, Oct 3, 2023 at 8:36 PM Christian Marangi wrote: > > Now that napi_schedule return a bool, we can drop napi_reschedule that > does the same exact function. The function comes from a very old commit > bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct > net_device")

[net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

2023-10-03 Thread Christian Marangi
Now that napi_schedule return a bool, we can drop napi_reschedule that does the same exact function. The function comes from a very old commit bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct net_device") and the purpose is actually deprecated in favour of different logic.