Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-10 Thread Geoff Levand
James Bottomley wrote: On Mon, 2009-02-09 at 11:11 +1100, Benjamin Herrenschmidt wrote: The PS3 platform code wants to use some of the standard SCSI types from there though, as they are part of the hypervisor ABI. (And in fact it can be argued that non-block devices using SCSI do exist, such

Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-10 Thread Sachin P. Sant
James Bottomley wrote: Actually, I think the fix lies in scsi.h ... we can make that into a nicely independent protocol header file. Your current woes come because it pulls in scsi_cmnd.h ... perhaps just getting rid of this will fix it. Can the rest of linux-scsi verify that the fix below

Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-08 Thread Michael Ellerman
On Fri, 2009-02-06 at 18:42 -0800, Geoff Levand wrote: Change the PS3 platform code to use hard coded numbers for its LV1 device types. The PS3 platform code was incorrectly using some scsi block constants for the device type returned from the LV1 hypervisor. Fixes build errors like these

Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-08 Thread Benjamin Herrenschmidt
On Sun, 2009-02-08 at 22:29 +1100, Michael Ellerman wrote: On Fri, 2009-02-06 at 18:42 -0800, Geoff Levand wrote: Change the PS3 platform code to use hard coded numbers for its LV1 device types. The PS3 platform code was incorrectly using some scsi block constants for the device type

Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-08 Thread James Bottomley
On Mon, 2009-02-09 at 11:11 +1100, Benjamin Herrenschmidt wrote: On Sun, 2009-02-08 at 22:29 +1100, Michael Ellerman wrote: On Fri, 2009-02-06 at 18:42 -0800, Geoff Levand wrote: Change the PS3 platform code to use hard coded numbers for its LV1 device types. The PS3 platform code

Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type

2009-02-07 Thread Sachin P. Sant
Geoff Levand wrote: Change the PS3 platform code to use hard coded numbers for its LV1 device types. The PS3 platform code was incorrectly using some scsi block constants for the device type returned from the LV1 hypervisor. Fixes build errors like these when CONFIG_BLOCK=n: In file