Re: [patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-11 Thread Benjamin Herrenschmidt
On Sat, 2009-10-10 at 15:37 +, Thomas Gleixner wrote: plain text document attachment (drivers-mac-ans-lcd-remove-bkl.patch) The ans-lcd driver got the cycle_kernel_lock() in anslcd_open() from the BKL pushdown and it still uses the locked ioctl. The BKL serialization in this driver is

Re: [patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-11 Thread John Kacur
On Sat, 10 Oct 2009, Thomas Gleixner wrote: The ans-lcd driver got the cycle_kernel_lock() in anslcd_open() from the BKL pushdown and it still uses the locked ioctl. The BKL serialization in this driver is more than obscure and definitely does not cover all possible corner cases. Protect

Re: [patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-11 Thread John Kacur
On Sun, 11 Oct 2009, Alan Cox wrote: There were 4 checkpatch errors on this patch, all of the type ERROR: spaces required around that '=' (ctx:WxO) #1466: FILE: drivers/macintosh/ans-lcd.c:112: + ret =-EACCES; Here's a suggestion. If a few spaces bug you that much

[patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-10 Thread Thomas Gleixner
The ans-lcd driver got the cycle_kernel_lock() in anslcd_open() from the BKL pushdown and it still uses the locked ioctl. The BKL serialization in this driver is more than obscure and definitely does not cover all possible corner cases. Protect the access to the hardware with a local mutex and

Re: [patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-10 Thread Alan Cox
There were 4 checkpatch errors on this patch, all of the type ERROR: spaces required around that '=' (ctx:WxO) #1466: FILE: drivers/macintosh/ans-lcd.c:112: + ret =-EACCES; Here's a suggestion. If a few spaces bug you that much then instead of complaining about it and