Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-03-03 Thread Bjorn Helgaas
On Monday 03 March 2008 11:45:06 am Jesse Barnes wrote: > On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: > > > > Not-Yet-Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> > > So you'd like to see the MIPS stuff cleaned up a bit more first before actual > sign-off? Or just more testi

Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-03-03 Thread Jesse Barnes
On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: > There are many implementations of pcibios_enable_resources() that differ > in minor ways that look more like bugs than architectural differences. > > This patch consolidates most of them to use the version annotated below. > This is the

Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-02-28 Thread David Howells
Bjorn Helgaas <[EMAIL PROTECTED]> wrote: > > frv: checks only 6 resources at (1), has a different ROM > resource check at (4) and (6) that ignores IORESOURCE_ROM_ENABLE > ... > mn10300: checks only 6 resources at (1), has no IORESOURCE_{IO,MEM} > check at (3), has a different

[patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-02-27 Thread Bjorn Helgaas
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch consolidates most of them to use the version annotated below. This is the original x86 version, except that it uses the resource collision chec