Re: [spi-devel-general] [PATCH v4] spi: Add PPC4xx SPI driver

2008-11-21 Thread Stefan Roese
Dave, On Friday 21 November 2008, David Brownell wrote: > On Friday 31 October 2008, Stefan Roese wrote: > > +   dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n", > > +   __FUNCTION__, spi->mode, spi->bits_per_word, > > +   spi->max_speed_hz); > > Oh, and checkpatch.pl

Re: [spi-devel-general] [PATCH v4] spi: Add PPC4xx SPI driver

2008-11-20 Thread David Brownell
On Friday 31 October 2008, Stefan Roese wrote: > +   dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n", > +   __FUNCTION__, spi->mode, spi->bits_per_word, > +   spi->max_speed_hz); Oh, and checkpatch.pl would warn about __FUNCTION__ vs __func__ ... _

Re: [spi-devel-general] [PATCH v4] spi: Add PPC4xx SPI driver

2008-11-20 Thread David Brownell
On Friday 31 October 2008, Stefan Roese wrote: > +static int spi_ppc4xx_setupxfer(struct spi_device *spi, struct spi_transfer > *t) > +{ > ... > > +   if (in_8(&hw->regs->cdm) != cdm) > +   out_8(&hw->regs->cdm, cdm); ... writes to hardware, updating SPI the clock ra