Re: [v2] cxl: Fix bug where AFU disable operation had no effect

2016-07-11 Thread Michael Ellerman
On Thu, 2016-30-06 at 16:50:40 UTC, Ian Munsie wrote: > From: Ian Munsie > > The AFU disable operation has a bug where it will not clear the enable > bit and therefore will have no effect. To date this has likely been > masked by fact that we perform an AFU reset before the disable, which > also

Re: [PATCH v2] cxl: Fix bug where AFU disable operation had no effect

2016-07-01 Thread Frederic Barrat
It looks good to me. I can live with the extra 'clear' parameter, because as you say, the approach I had suggested would require more testing, so let's play safe for the time being. And thanks for clarifying/fixing the deactivate paths. Reviewed-by: Frederic Barrat Fred Le 30/06/2016 18:5

[PATCH v2] cxl: Fix bug where AFU disable operation had no effect

2016-06-30 Thread Ian Munsie
From: Ian Munsie The AFU disable operation has a bug where it will not clear the enable bit and therefore will have no effect. To date this has likely been masked by fact that we perform an AFU reset before the disable, which also has the effect of clearing the enable bit, making the following di