Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-11-04 Thread youling 257
This driver https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c 2019-11-04 16:02 GMT+08:00, Takashi Iwai : > Exactly which driver is hit? The code path is via hw_support_mmap() > and it's currently: > > static bool

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-11-04 Thread youling257
This patch cause oops on android mainline kernel about gadget audio_source. Androidx86 run on android mainline kernel. [ 385.104963] android_work: sent uevent USB_STATE=CONNECTED [ 385.109006] android_work: sent uevent USB_STATE=DISCONNECTED [ 385.182024] android_work: sent uevent

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-11-04 Thread youling 257
Kernel panic - not syncing: Fatal exception [ 385.296985] Kernel Offset: 0x33e0 from 0x8100 (relocation range: 0x8000-0xbfff) [ 385.305185] Rebooting in 5 seconds.. Revert it no the oops. Revert "ALSA: pcm: use dma_can_mmap() to check if a device s

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-11-04 Thread Takashi Iwai
On Mon, 04 Nov 2019 09:49:43 +0100, Greg Kroah-Hartman wrote: > > On 11/4/19 9:32 AM, Greg Kroah-Hartman wrote: > > On 11/4/19 9:27 AM, youling 257 wrote: > > > This driver > > >

Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-11-04 Thread Takashi Iwai
On Mon, 04 Nov 2019 08:06:37 +0100, youling 257 wrote: > > This patch cause oops on android mainline kernel about gadget audio_source. > Androidx86 run on android mainline kernel. > > [ 385.104963] android_work: sent uevent USB_STATE=CONNECTED > [ 385.109006] android_work: sent uevent

[PATCH 5/8] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-08-08 Thread Christoph Hellwig
Replace the local hack with the dma_can_mmap helper to check if a given device supports mapping DMA allocations to userspace. Signed-off-by: Christoph Hellwig Reviewed-by: Takashi Iwai --- sound/core/pcm_native.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-08-06 Thread Takashi Iwai
On Tue, 06 Aug 2019 07:29:49 +0200, Christoph Hellwig wrote: > > On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote: > > This won't work as expected, unfortunately. It's a bit tricky check, > > since the driver may have its own mmap implementation via > > substream->ops->mmap, and the

Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-08-05 Thread Christoph Hellwig
On Mon, Aug 05, 2019 at 11:22:03AM +0200, Takashi Iwai wrote: > This won't work as expected, unfortunately. It's a bit tricky check, > since the driver may have its own mmap implementation via > substream->ops->mmap, and the dma_buffer.dev.dev might point to > another object depending on the

Re: [PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-08-05 Thread Takashi Iwai
On Mon, 05 Aug 2019 11:11:56 +0200, Christoph Hellwig wrote: > > Replace the local hack with the dma_can_mmap helper to check if > a given device supports mapping DMA allocations to userspace. > > Signed-off-by: Christoph Hellwig > --- > sound/core/pcm_native.c | 5 ++--- > 1 file changed, 2

[PATCH 4/7] ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*

2019-08-05 Thread Christoph Hellwig
Replace the local hack with the dma_can_mmap helper to check if a given device supports mapping DMA allocations to userspace. Signed-off-by: Christoph Hellwig --- sound/core/pcm_native.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_native.c