Re: IDE cable detection on Apple PowerBook

2009-03-20 Thread Benjamin Herrenschmidt
On Thu, 2009-03-19 at 22:30 +0900, TOMARI Hisanobu wrote: Thanks for helpful advices. This patch adds an option to drivers/ide/Kconfig and adds some lines to drivers/ide/pmac.c . Now the driver checks if the model is prefixed with PowerBook and the entire hack can be toggled in the Kconfig.

Re: [Fwd: Re: IDE cable detection on Apple PowerBook]

2009-03-20 Thread TOMARI Hisanobu
On Fri, 20 Mar 2009 12:40:29 +0100 Bartlomiej Zolnierkiewicz bzoln...@gmail.com wrote: Moreover the underlying issue is non-PMAC specific and asks for generic resolution, please see: http://bugzilla.kernel.org/show_bug.cgi?id=12734#c13 for previous discussion. In the very least

Re: IDE cable detection on Apple PowerBook

2009-03-19 Thread Benjamin Herrenschmidt
On Wed, 2009-03-18 at 22:47 +0900, TOMARI Hisanobu wrote: I thought the short-40pin assumption would cause no problem considering all models beginning with PowerBook5 are laptops. Do you mean an option to toggle this hack on/off should be present in Kconfig? Actually, it makes -some- amount

Re: IDE cable detection on Apple PowerBook

2009-03-19 Thread Benjamin Herrenschmidt
On Thu, 2009-03-19 at 17:07 +1100, Benjamin Herrenschmidt wrote: On Wed, 2009-03-18 at 22:47 +0900, TOMARI Hisanobu wrote: I thought the short-40pin assumption would cause no problem considering all models beginning with PowerBook5 are laptops. Do you mean an option to toggle this hack

Re: IDE cable detection on Apple PowerBook

2009-03-19 Thread TOMARI Hisanobu
Thanks for helpful advices. This patch adds an option to drivers/ide/Kconfig and adds some lines to drivers/ide/pmac.c . Now the driver checks if the model is prefixed with PowerBook and the entire hack can be toggled in the Kconfig. Again, the patch is against linux 2.6.28.8. Best regards,

Re: IDE cable detection on Apple PowerBook

2009-03-19 Thread Anton Vorontsov
On Thu, Mar 19, 2009 at 10:30:01PM +0900, TOMARI Hisanobu wrote: Thanks for helpful advices. This patch adds an option to drivers/ide/Kconfig and adds some lines to drivers/ide/pmac.c . I think it would be better to make it a kernel command line option instead of Kconfig knob. The reason is:

Re: IDE cable detection on Apple PowerBook

2009-03-19 Thread Benjamin Herrenschmidt
On Thu, 2009-03-19 at 16:41 +0300, Anton Vorontsov wrote: The other option is to enable BLK_DEV_IDE_PMAC_SHORTCABLE by default, but I'm not sure if it's safe thing to do (most probably not). It should be allright for powerbooks. If the firmware says 80 pin cable, then it probably is, and in

Re: IDE cable detection on Apple PowerBook

2009-03-18 Thread Benjamin Herrenschmidt
On Wed, 2009-03-18 at 14:06 +0900, TOMARI Hisanobu wrote: Hello, I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer. The IDE drive fails to recognize 80-conductor cable that connects the drive to motherboard to fall back to UDMA33. This patch fixes this behavior by assuming that the

Re: IDE cable detection on Apple PowerBook

2009-03-18 Thread TOMARI Hisanobu
I thought the short-40pin assumption would cause no problem considering all models beginning with PowerBook5 are laptops. Do you mean an option to toggle this hack on/off should be present in Kconfig? Thanks, TOMARI Hisanobu On Wed, 18 Mar 2009 18:58:17 +1100 Benjamin Herrenschmidt

IDE cable detection on Apple PowerBook

2009-03-17 Thread TOMARI Hisanobu
Hello, I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer. The IDE drive fails to recognize 80-conductor cable that connects the drive to motherboard to fall back to UDMA33. This patch fixes this behavior by assuming that the cable is short-40pin when the model string matches PowerBook5