Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Tabi Timur-B04825
On Wed, Oct 12, 2011 at 3:57 PM, Kumar Gala ga...@kernel.crashing.org wrote: From: Kai Jiang kai.ji...@freescale.com To support 32-bit physical addresses for UIO_MEM_PHYS type we need to extend the width of 'addr' in struct uio_mem.  Numerous platforms like embedded PPC, ARM, and X86 have

Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Kumar Gala
On Oct 13, 2011, at 9:37 AM, Tabi Timur-B04825 wrote: On Wed, Oct 12, 2011 at 3:57 PM, Kumar Gala ga...@kernel.crashing.org wrote: From: Kai Jiang kai.ji...@freescale.com To support 32-bit physical addresses for UIO_MEM_PHYS type we need to extend the width of 'addr' in struct uio_mem.

Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Timur Tabi
David Laight wrote: Since there is a discriminating field, could a union be used? At a guess the type of the address is constrained between produces and consumer?? I don't think we need to complicate the code by changing that variable into a union. I just a want a short comment added to the

RE: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread David Laight
Kumar Gala wrote: + phys_addr_t addr; Please add a comment here saying: 1) That 'addr' can be a virtual or physical address The code and everything else makes that clear I'm sorry, but I have to strongly disagree here. It is *NOT* clear that a variable

Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Kumar Gala
On Oct 13, 2011, at 10:37 AM, David Laight wrote: Kumar Gala wrote: + phys_addr_t addr; Please add a comment here saying: 1) That 'addr' can be a virtual or physical address The code and everything else makes that clear I'm sorry, but I have to strongly disagree