On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote:
Are you suggesting we leave those warnings there until somebody decides
to fix all the portability issues of this driver? My patch is a small
and insignificant improvement and not the revolution you're asking for,
but is
Hello David,
No piece of code in the kernel should live in a vacuum.
In order to improve overall code quality, every piece of
driver code should avoid assuming things about pointer
sizes and things of this nature.
I'm afraid we might be talking about orthogonal issues here. I actively
-Original Message-
From: Medve Emilian-EMMEDVE1
Sent: Monday, October 22, 2007 9:48 PM
To: David Miller
Cc: [EMAIL PROTECTED]; Li Yang-r58472;
[EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings
Hello David
From: Medve Emilian-EMMEDVE1 [EMAIL PROTECTED]
Date: Fri, 19 Oct 2007 06:39:12 -0700
For the current situation, 32-bit QE, 32-bit PowerPC, do you find
the patch acceptable?
No piece of code in the kernel should live in a vacuum.
In order to improve overall code quality, every piece of
driver
Hello David
It only kills the warning on 32-bit systems, the cast is wrong
either way.
I'm not aware of the QE being present on any 64-bit PowerPC. However,
porting the entire driver to a 64-bit platform is an exercise in itself
as many other things would need tweaking the QE hardware itself.
Emil Medve wrote:
drivers/net/ucc_geth.c: In function 'ucc_geth_startup':
drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer
without a cast
drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer
without a cast
Signed-off-by: Emil Medve [EMAIL
From: Emil Medve [EMAIL PROTECTED]
Date: Thu, 18 Oct 2007 17:15:13 -0500
drivers/net/ucc_geth.c: In function 'ucc_geth_startup':
drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer
without a cast
drivers/net/ucc_geth.c:2651: warning: assignment makes integer from
