RE: [PATCH] kbuild: single-quote the format string of printf

2023-08-30 Thread David Laight
... > All of "\\n", "\n", '\n' are the same. and \\n (without any quote characters at all). Personally I'd use 'format' for printf. To make it obvious that nothing is to be expanded. But it isn't really worth changing existing 'stuff'. David - Registered Address Lakeside, Bramley Road,

Re: [PATCH] kbuild: single-quote the format string of printf

2023-08-30 Thread Masahiro Yamada
On Wed, Aug 30, 2023 at 10:00 AM Nicolas Schier wrote: > > On Tue 29 Aug 2023 20:35:31 GMT, Masahiro Yamada wrote: > > Use single-quotes to avoid escape sequences (\\n). > > > > Signed-off-by: Masahiro Yamada > > --- > > Is this really necessary? Testing w/ GNU Make 4.3, bash 5.2.15 or > dash 0.

Re: [PATCH] kbuild: single-quote the format string of printf

2023-08-29 Thread Nicolas Schier
On Tue 29 Aug 2023 20:35:31 GMT, Masahiro Yamada wrote: > Use single-quotes to avoid escape sequences (\\n). > > Signed-off-by: Masahiro Yamada > --- Is this really necessary? Testing w/ GNU Make 4.3, bash 5.2.15 or dash 0.5.12-6 and a stupid Makefile snippet I cannot see any difference betwee