Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-05 Thread Felipe Balbi
ger.kernel.org; > linuxppc-dev@lists.ozlabs.org; g...@kroah.com; > > Fushen Chen; Mark Miesfeld > > Subject: Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core > Interface Layer (CIL) > > > > Hello. > > > > Tirumala Marri wrote: > > > > &

RE: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-05 Thread Keshava Munegowda
; Subject: Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL) > > Hello. > > Tirumala Marri wrote: > > >>> +void dwc_otg_core_init(struct core_if *core_if) > >>> +{ > >>> + u32 i; > >>> + ulong global

Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-01 Thread Sergei Shtylyov
Hello. Tirumala Marri wrote: +void dwc_otg_core_init(struct core_if *core_if) +{ + u32 i; + ulong global_reg = core_if->core_global_regs; + struct device_if *dev_if = core_if->dev_if; + u32 ahbcfg = 0; + u32 i2cctl = 0; + u32 gusbcfg; Tabify the declaratio

RE: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-01 Thread Tirumala Marri
> +void dwc_otg_core_init(struct core_if *core_if) > +{ > + u32 i; > + ulong global_reg = core_if->core_global_regs; > + struct device_if *dev_if = core_if->dev_if; > + u32 ahbcfg = 0; > + u32 i2cctl = 0; > + u32 gusbcfg; Tabify the declarations ; [Marri] When I checked aga