RE: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-20 Thread Bounine, Alexandre
Andrew Morton a...@linux-foundation.org wrote: @@ -219,6 +219,7 @@ struct rio_net { /** * struct rio_switch - RIO switch info * @node: Node in global list of switches + * @rdev: Associated RIO device structure * @switchid: Switch ID that is unique across a network *

Re: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-20 Thread Andrew Morton
On Mon, 20 Sep 2010 07:31:22 -0700 Bounine, Alexandre alexandre.boun...@idt.com wrote: Andrew Morton a...@linux-foundation.org wrote: @@ -219,6 +219,7 @@ struct rio_net { /** * struct rio_switch - RIO switch info * @node: Node in global list of switches + * @rdev:

RE: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-20 Thread Bounine, Alexandre
Andrew Morton a...@linux-foundation.org wrote: The variable length array at the end of the struct thing is pretty commonly used and works well. As long as we never want to change the number of switches on the fly (hotplug?). This is expected to be a strange array - its size can be 0 or 1

Re: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-20 Thread Micha Nelissen
Hi Alex, Bounine, Alexandre wrote: struct rio_dev { struct list_head global_list; struct list_head net_list; . . rest of rio_dev . struct rio_switch switch[0]; } It makes sense to let rio_dev structures point to the switch they are attached to. That can be

Re: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:16 -0400 Alexandre Bounine alexandre.boun...@idt.com wrote: @@ -219,6 +219,7 @@ struct rio_net { /** * struct rio_switch - RIO switch info * @node: Node in global list of switches + * @rdev: Associated RIO device structure * @switchid: Switch ID that is