Re: [PATCH v5 1/4] KVM: PPC: epapr: Factor out the epapr init

2012-02-22 Thread Scott Wood
On 02/21/2012 08:33 PM, Liu Yu-B13201 wrote: +bool epapr_para_enabled = false; No need to explicitly initialize to false. Why not make code more readable? It's common kernel style to not explicitly initialize global data to zero or equivalent. Historically this was due to toolchain issues

Re: [PATCH v5 1/4] KVM: PPC: epapr: Factor out the epapr init

2012-02-21 Thread Scott Wood
On 02/20/2012 10:46 PM, Liu Yu wrote: from the kvm guest paravirt init code. Signed-off-by: Liu Yu yu@freescale.com --- v5: 1. fix the if test 2. use patch_instruction() 3. code cleanup 4. rename the files 5. make epapr paravirt user-selectable

RE: [PATCH v5 1/4] KVM: PPC: epapr: Factor out the epapr init

2012-02-21 Thread Liu Yu-B13201
-Original Message- From: Wood Scott-B07421 Sent: Wednesday, February 22, 2012 5:56 AM To: Liu Yu-B13201 Cc: ag...@suse.de; kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc-...@ozlabs.org; Wood Scott-B07421 Subject: Re: [PATCH v5 1/4] KVM: PPC: epapr: Factor out the epapr