On 2018/1/31 23:30, Dan Carpenter <dan.carpen...@oracle.com> wrote
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: 2018年1月31日 23:30
To: Qiang Zhao <qiang.z...@nxp.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: [bug report] fsl/qe: setup clock source for TDM mode
Hello Zhao Qiang,
The patch bb8b2062aff3: "fsl/qe: setup clock source for TDM mode"
from Jun 6, 2016, leads to the following static checker warning:
drivers/soc/fsl/qe/ucc.c:629 ucc_get_tdm_sync_shift()
warn: both sides of ternary the same: '30' RX_SYNC_SHIFT_BASE
RX_SYNC_SHIFT_BASE
drivers/soc/fsl/qe/ucc.c
625 static u32 ucc_get_tdm_sync_shift(enum comm_dir mode, u32 tdm_num)
626 {
627 u32 shift;
628
629 shift = (mode == COMM_DIR_RX) ? RX_SYNC_SHIFT_BASE :
RX_SYNC_SHIFT_BASE;
^^^^^^^^^^^^^^^^^^
Maybe this one should have been TX_?
Thank you very much, it is a typo, I will send a patch to fix it.
BR
Qiang Zhao
